"My email adresses" and "Addresses to not send responses to" fields are not checked for valid email address

When using ingo to setup a vacation message, the email adres

Thu, 28 Aug 2008 13:59:01 +0000

When using ingo to setup a vacation message, the email adresses enter in the "My email adresses" and "Addresses to not send responses to" are not checked for validity. This can cause a problem with the rules driver, for example sieve will return an error message is the email address is not rfc 822 compliant.

I propose a possible solution for that bug with the attached

Thu, 28 Aug 2008 14:23:09 +0000

I propose a possible solution for that bug with the attached patch. I created a Horde_Form_Type_longemail class extended from Horde_Form_Type_longtext, which in addition checks the validity of the given emails. What do you think about this solution ? You will notice that the longemail type also checks if the email address have a @domain part, I am not sure if this should be done here. sieve doesn't like address without domain, it complains with the following error: script errors: line 8: address 'test': parse error, unexpected $, expecting '@' but that might be solved differently by adding the default domain to unqualified address before sending them to the sieve driver.

This breaks backward compatibility. Either you have to check

Sat, 30 Aug 2008 09:01:40 +0000

This breaks backward compatibility. Either you have to check the validity outside of the form validation, or you have add the new form field type to Ingo only.

I didn't understand how the new type breaks comptability or

Sat, 30 Aug 2008 09:55:53 +0000

I didn't understand how the new type breaks comptability or how adding the new type in Ingo only solves the problem. Could you explain me so I can improve the patch ?

Any Ingo 1.x version has to be compatible to any Horde 3.x v

Sun, 31 Aug 2008 17:00:23 +0000

Any Ingo 1.x version has to be compatible to any Horde 3.x version. So you can't simply add a feature to Horde and use it an application like Ingo without breaking that backward compatibility.

Ok, I understand. I modified my patch so the longemail ty

Mon, 01 Sep 2008 12:21:49 +0000

Ok, I understand. I modified my patch so the longemail type is defined only in ingo. Note that this patch still considers an address without the domain part to be invalid. Is this behavior ok ?

I think that's fine.

Mon, 01 Sep 2008 12:28:43 +0000

I think that's fine.

I updated the patch to fix a little mistake and also to use

Thu, 11 Sep 2008 09:46:45 +0000

I updated the patch to fix a little mistake and also to use the new longemail form type also for the "Address(es) to forward to" field for transfert.

I hope I didn't delete the wrong patch accidentally, but the

Mon, 22 Sep 2008 16:59:37 +0000

I hope I didn't delete the wrong patch accidentally, but the latest version does not contain the actual code for the Horde_Form_Type_longemail class.

My mistake, here is the good updated patch.

Tue, 23 Sep 2008 10:21:01 +0000

My mistake, here is the good updated patch.

Is this ticket still slated for a FRAMEWORK_3 version or sho

Sun, 02 Aug 2009 13:33:29 +0000

Is this ticket still slated for a FRAMEWORK_3 version or should it be moved to Git queue?

Ingo 3.2. commit c3eedc5d53c1dc6d30b39d568fb9a40c388420

Fri, 01 Nov 2013 03:26:29 +0000

Ingo 3.2. commit c3eedc5d53c1dc6d30b39d568fb9a40c388420f4 Author: Michael M Slusarz Date: Thu Oct 31 21:25:22 2013 -0600 [mms] Validate e-mail addresses ion the forward and vacation pages (Request #7249). ingo/docs/CHANGES | 2 + ingo/lib/Basic/Forward.php | 8 ++++- ingo/lib/Basic/Vacation.php | 5 ++- ingo/lib/Form/Forward.php | 2 +- ingo/lib/Form/Type/Longemail.php | 68 ++++++++++++++++++++++++++++++++++++++ ingo/lib/Form/Vacation.php | 6 ++-- ingo/lib/Ui/VarRenderer/Ingo.php | 13 +++++++ ingo/package.xml | 11 ++++-- 8 files changed, 106 insertions(+), 9 deletions(-) create mode 100644 ingo/lib/Form/Type/Longemail.php http://github.com/horde/horde/commit/c3eedc5d53c1dc6d30b39d568fb9a40c388420f4 http://git.horde.org/horde-git/-/commit/c3eedc5d53c1dc6d30b39d568fb9a40c388420f4

Changes have been made in Git (master): commit c3eedc5d53c1

Tue, 17 Dec 2013 11:17:14 +0000

Changes have been made in Git (master): commit c3eedc5d53c1dc6d30b39d568fb9a40c388420f4 Author: Michael M Slusarz Date: Thu Oct 31 21:25:22 2013 -0600 [mms] Validate e-mail addresses ion the forward and vacation pages (Request #7249). ingo/docs/CHANGES | 2 + ingo/lib/Basic/Forward.php | 8 ++++- ingo/lib/Basic/Vacation.php | 5 ++- ingo/lib/Form/Forward.php | 2 +- ingo/lib/Form/Type/Longemail.php | 68 ++++++++++++++++++++++++++++++++++++++ ingo/lib/Form/Vacation.php | 6 ++-- ingo/lib/Ui/VarRenderer/Ingo.php | 13 +++++++ ingo/package.xml | 11 ++++-- 8 files changed, 106 insertions(+), 9 deletions(-) http://git.horde.org/horde-git/-/commit/c3eedc5d53c1dc6d30b39d568fb9a40c388420f4