listing alarms of recurring events which cross a day boundary

The function mentioned above does not handle recurring event

Sun, 06 Jul 2008 20:02:29 +0000

The function mentioned above does not handle recurring events correctly which cross a day boundary. The patch attached fixes this.

Please provide a test case to reproduce this.

Sun, 06 Jul 2008 22:27:23 +0000

Please provide a test case to reproduce this.

> Please provide a test case to reproduce this. Suppose y

Mon, 07 Jul 2008 06:46:30 +0000

> Please provide a test case to reproduce this. Suppose you have a recurring event each Monday, 16:00 to the following Tuesday, 12:00 with an alarm of 15 minutes before start. Let's assume it is Monday, 2008-07-07, 15:45, stored in $date. Then the old code $start = new Horde_Date($next); $start->min -= $event->getAlarm(); $start->correct(); $end = new Horde_Date(array( 'year' => $next->year, 'month' => $next->month, 'mday' => $next->mday, 'hour' => $event->end->hour, 'min' => $event->end->min, 'sec' => $event->end->sec)); assigns "2008-07-07 15:45" to $start and "2008-07-07 12:00" to $end. Now the second part of the following comparison if ($start->compareDateTime($date) <= 0 && $date->compareDateTime($end) <= -1) fails, as $date ("2008-07-07 15:45") does not come before $end ("2008-07-07 12:00"). The patch fixes this by assigning the correct event end "2008-07-08 12:00" to $end.

The fix is almost correct, but it doesn't consider DST switc

Wed, 30 Jul 2008 22:59:40 +0000

The fix is almost correct, but it doesn't consider DST switched during the event.

Changes have been made in CVS for this ticket: http://cvs.h

Wed, 20 Aug 2008 16:07:34 +0000

Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/kronolith/lib/Driver/sql.php?r1=1.208&r2=1.209&ty=u

Fixed in CVS.

Wed, 20 Aug 2008 16:08:52 +0000

Fixed in CVS.