Unclear error message in compose window when profile's from address is invalid

If a user's profile has a From address that does not pass va

Tue, 17 Jun 2008 13:37:42 +0000

If a user's profile has a From address that does not pass validation, the user is prevented from sending mail and is given this error message: "Validation failed for: Joe User " This can be confusing for the user and it would be nice to have a more helpful error message. I've attached a patch with extends the error message to read: "Validation failed for: Joe User Your From address is not a valid email address. This can be fixed in your Personal Information options page." This allows users to immediately jump to the place where they can fix the problem. (Is there a better way to link to the "Personal Information" pref page?)

I like the idea of a better error message, but linking to th

Wed, 18 Jun 2008 21:23:56 +0000

I like the idea of a better error message, but linking to the preference page is not so good in this very case. Opening the preference page in a new window is bad usability (see the category color popup, it's horrible). And since the compose window can be both, in the horde frame, or in a popup window, we can't target the current window either. I think it would be better to only tell the user what to do. And the message should be extended earlier in the code, in getFromLine(). Also, please use getMessage() instead of accessing the message property directly.

Why isn't this validation being done when the user enters th

Sat, 21 Jun 2008 17:46:56 +0000

Why isn't this validation being done when the user enters the e-mail address in the identities page? That would make the most sense.

> I think it would be better to only tell the user what to

Tue, 24 Jun 2008 20:27:05 +0000

> I think it would be better to only tell the user what to do. And the > message should be extended earlier in the code, in getFromLine(). > Also, please use getMessage() instead of accessing the message > property directly. I've attached a new patch, which just extends the error message, and does so in getFromLine().

> Why isn't this validation being done when the user enters

Tue, 24 Jun 2008 20:29:10 +0000

> Why isn't this validation being done when the user enters the e-mail > address in the identities page? That would make the most sense. It is done there. Some of our user's identities contain invalid from addresses because we migrated our data before the upgrade script validated those addresses.

Changes have been made in CVS for this ticket: http://cvs.h

Wed, 25 Jun 2008 04:00:56 +0000

Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/imp/docs/CHANGES?r1=1.1144&r2=1.1145&ty=u http://cvs.horde.org/diff.php/imp/lib/Identity/imp.php?r1=1.78&r2=1.79&ty=u

Switched to using a gettext message (for translation) and co

Wed, 25 Jun 2008 04:01:20 +0000

Switched to using a gettext message (for translation) and committed - thanks!