Fri, 10 Apr 2026 01:27:08 +0000 https://bugs.horde.org/ticket/6897 Fix import of multiple email addresses Hello together :-) Attached patch fixes the import of multiple email addresses. Needs the patch from bug #6896 to work properly. I also added code to check the return value of $rfc822->validateMailbox() to prevent data loss and warning messages like this: [Tue Jun 10 14:20:58 2008] [error] [client 172.16.1.2] PHP Notice: Trying to get property of non-object in /usr/intranator/html/horde/turba/data.php on line 64, referer: http://intradev.m.i2n/horde/turba/data.php Cheers, Thomas Wed, 11 Jun 2008 08:47:45 +0000 https://bugs.horde.org/ticket/6897#t46250 If something doesn't validate, then we shouldn't be letting it into the email field - that's half the point of this function... Wed, 11 Jun 2008 20:29:15 +0000 https://bugs.horde.org/ticket/6897#t46284 > If something doesn't validate, then we shouldn't be letting it into > the email field - that's half the point of this function... I got the impression the function was there to strip of the "personal" part of an email address. Well, if it also was intended as validation, then we should inform the user if something went wrong. IMHO it would be ok to import the "bad" data and the user can correct it later. But I'm okay with the change, if you want to you can modify the code to output a notification including the failing address and skip it from $results. Thu, 12 Jun 2008 07:30:04 +0000 https://bugs.horde.org/ticket/6897#t46301 > I got the impression the function was there to strip of the > "personal" part of an email address. ...which ensures that it's a valid value for an 'email' field. > IMHO it would be ok to import the "bad" data and the user can correct > it later. Don't agree with that. Thu, 12 Jun 2008 14:27:52 +0000 https://bugs.horde.org/ticket/6897#t46317 Thomas - ping? Mon, 30 Jun 2008 18:56:29 +0000 https://bugs.horde.org/ticket/6897#t47028 > Thomas - ping? Hey :-) Thought this made my point: "But I'm okay with the change, if you want to you can modify the code to output a notification including the failing address and skip it from $results." -> Do as you like, but with fix the import of multiple email addresses :-) Tue, 01 Jul 2008 07:08:19 +0000 https://bugs.horde.org/ticket/6897#t47064 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/turba/data.php?r1=1.104&r2=1.105&ty=u http://cvs.horde.org/diff.php/turba/docs/CHANGES?r1=1.430&r2=1.431&ty=u Wed, 02 Jul 2008 06:36:49 +0000 https://bugs.horde.org/ticket/6897#t47087 Thanks, Chuck! We should check the return code of $rfc822->validateMailbox() though as this will lead to nasty PHP warnings if you throw an invalid address at _getBareEmail(). Wed, 02 Jul 2008 07:10:45 +0000 https://bugs.horde.org/ticket/6897#t47091 This just uses the same logic as previously. If there was a separate problem with that, can you please create a ticket with example data, and ideally a test? Thanks! Wed, 02 Jul 2008 15:30:11 +0000 https://bugs.horde.org/ticket/6897#t47116 > This just uses the same logic as previously. If there was a separate > problem with that, can you please create a ticket with example data, > and ideally a test? Well, it was part of the problem description in the first comment of this bug. I'm still in favor of applying the complete patch and then just change the code to discard email addresses which don't validate. A warning message about the invalid email address would be nice to have, but is not a must. Thu, 03 Jul 2008 07:15:57 +0000 https://bugs.horde.org/ticket/6897#t47162 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/turba/data.php?r1=1.105&r2=1.106&ty=u Sun, 06 Jul 2008 03:31:14 +0000 https://bugs.horde.org/ticket/6897#t47245