Fri, 10 Apr 2026 12:52:13 +0000 https://bugs.horde.org/ticket/6822 Hooked prefs won't get stored Hooked and non-locked prefs won't get stored any more. / manuel Patch: --- ./lib/Horde/Prefs.php.orig 2008-06-02 22:49:59.000000000 +0200 +++ ./lib/Horde/Prefs.php 2008-06-02 22:57:34.000000000 +0200 @@ -766,6 +766,7 @@ $this->_scopes[$scope][$name]['m'] & _PREF_DEFAULT) { $val = Horde::callHook('_prefs_hook_' . $name, array($this->_user), 'horde', $name); $this->_scopes[$scope][$name]['v'] = $this->convertToDriver($val, NLS::getCharset()); + $this->_scopes[$scope][$name]['m'] |= _PREF_DIRTY; } } } Mon, 02 Jun 2008 21:03:28 +0000 https://bugs.horde.org/ticket/6822#t45830 Why isn't this the right behavior? Tue, 03 Jun 2008 02:05:56 +0000 https://bugs.horde.org/ticket/6822#t45845 > Why isn't this the right behavior? #1 It's not documented that way (from hooks.php) * NOTE 3: Any preference that is NOT LOCKED, that is set by a hook, WILL BE * SAVED WITH THAT VALUE. This means several things: * 1) Users will get the results of the hook set for them in their * preferences. * 2) By virtue of this, the next time they log in and load their * preferences, the hook will NOT be called, because in their last session, * we saved the results of the hook for them. However, if the preference is * locked, the result of the hook will never be saved. #2 We're hooking a lot of preferences for initial setup. If they won't be stored any more, this will generate a bunch of unnecessary SQL querys. #3 Why should unlocked prefs not get stored? (counter question) Tue, 03 Jun 2008 08:14:52 +0000 https://bugs.horde.org/ticket/6822#t45864 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/Prefs/Prefs.php?r1=1.192&r2=1.193&ty=u http://cvs.horde.org/diff.php/horde/docs/CHANGES?r1=1.1100&r2=1.1101&ty=u Sun, 08 Jun 2008 15:53:32 +0000 https://bugs.horde.org/ticket/6822#t46094 True enough. I fixed the patch to only store if the pref is unlocked and committed it - thanks. Sun, 08 Jun 2008 15:53:58 +0000 https://bugs.horde.org/ticket/6822#t46095 It's been a while, but I just found out that your fix is not correct. Your fix add the dirty bit to locked preferences. But in fact it should mark them if they are NOT locked. So please negate the if condition. Sun, 25 Jan 2009 16:02:08 +0000 https://bugs.horde.org/ticket/6822#t51952 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/Prefs/Prefs.php?rt=horde&r1=1.196&r2=1.197&ty=u http://cvs.horde.org/diff.php/horde/docs/CHANGES?rt=horde&r1=1.1201&r2=1.1202&ty=u Wed, 04 Feb 2009 21:45:21 +0000 https://bugs.horde.org/ticket/6822#t52278 Thanks for the catch. Wed, 04 Feb 2009 21:46:17 +0000 https://bugs.horde.org/ticket/6822#t52279 ! (not) has higher precedence than bitwise &, so there should be brackets too. if (!($this->_scopes[$scope][$name]['m'] & _PREF_LOCKED)) { ... } Thu, 05 Feb 2009 12:38:08 +0000 https://bugs.horde.org/ticket/6822#t52298 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/Prefs/Prefs.php?rt=horde&r1=1.197&r2=1.198&ty=u Thu, 05 Feb 2009 20:59:30 +0000 https://bugs.horde.org/ticket/6822#t52307 *sigh*, thanks Thu, 05 Feb 2009 21:00:25 +0000 https://bugs.horde.org/ticket/6822#t52308