Fri, 10 Apr 2026 09:21:00 +0000 https://bugs.horde.org/ticket/6796 "add ... to My Address Book" problems based on composite name field I wasn't sure if this was a Turba problem or an IMP problem. The "Add ... to my Address Book" button depends on the "name" field definition for the source defined by $_prefs['add_source']. In Turba 2.2, SQL based address books have split the name field up into it's component fields - first, last, middle, prefix, suffix, etc.. The default version of "name" is a composite version of all of those fields, though an abbreviated "first and last only" version is given as an example in the comments. If you use the "full" version of the name field definition, "Add ... to my Address Book" doesn't work, because the SQL it generates tries to match too many things: SELECT object_id, owner_id, object_type, object_members, object_uid, object_firstname, object_lastname, object_middlenames, object_nameprefix, object_namesuffix, object_alias, object_bday, object_homestreet, object_homepob, object_homecity, object_homeprovince, object_homepostalcode, object_homecountry, object_workstreet, object_workpob, object_workcity, object_workprovince, object_workpostalcode, object_workcountry, object_tz, object_email, object_homephone, object_workphone, object_cellphone, object_fax, object_pager, object_title, object_role, object_company, object_category, object_notes, object_url, object_freebusyurl, object_pgppublickey, object_smimepublickey FROM turba_objects WHERE ( owner_id = 'liamr' AND ( ( (LOWER(object_nameprefix) LIKE LOWER('%Joe%') OR LOWER(object_nameprefix) LIKE LOWER('%User%')) AND (LOWER(object_firstname) LIKE LOWER('%Joe%') OR LOWER(object_firstname) LIKE LOWER('%User%')) AND (LOWER(object_middlenames) LIKE LOWER('%Joe%') OR LOWER(object_middlenames) LIKE LOWER('%User%')) AND (LOWER(object_lastname) LIKE LOWER('%Joe%') OR LOWER(object_lastname) LIKE LOWER('%User%')) AND (LOWER(object_namesuffix) LIKE LOWER('%Joe%') OR LOWER(object_namesuffix) LIKE LOWER('%User%')) ) AND LOWER(object_email) LIKE LOWER('%juser@example.edu%') ) ) I guess it's possible it might work with a name that had all the components ("Mr. Joseph Xavier User III"), but his SQL won't ever match when given a name only made up of a first and last name. Since it doesn't match, "Add ... to my Address Book" will allow you to add the same address over and over again to your address book. If you use the shorter version of the composite name field (first and last only), you can add an address once, and subsequent attempts are met with a notices that the entry "Already Exists". Chuck thought it was a bug.. http://marc.info/?l=imp&m=121211283608734&w=2 Fri, 30 May 2008 14:08:40 +0000 https://bugs.horde.org/ticket/6796#t45697 ...this is most definitely a Turba issue. Sat, 14 Jun 2008 19:42:01 +0000 https://bugs.horde.org/ticket/6796#t46473 This patch fixes the issue. It's tested with SQL driver, but I would appreciate feedback/testing with other drivers before it gets committed. Basically, adds an additional check on each of the individual fields the composite field is composed of that allows that field to be empty. The SQL driver was patched to turn a check for '=' or 'LIKE' against an empty string to also include a check for IS NULL. Sun, 15 Jun 2008 18:55:24 +0000 https://bugs.horde.org/ticket/6796#t46512 Works okay for me. Mon, 16 Jun 2008 17:17:39 +0000 https://bugs.horde.org/ticket/6796#t46576 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/turba/lib/Driver.php?r1=1.198&r2=1.199&ty=u http://cvs.horde.org/diff.php/turba/lib/Driver/sql.php?r1=1.114&r2=1.115&ty=u Mon, 16 Jun 2008 18:54:45 +0000 https://bugs.horde.org/ticket/6796#t46582 Fixed for Turba 2.2.2 Mon, 16 Jun 2008 18:58:15 +0000 https://bugs.horde.org/ticket/6796#t46583 This completely broke listing of all address book entries when not using a composite name field, e.g. in imp's address book popup or the clients listing in hermes. With these changes only contacts that don't have a name are listed. To list all contacts of an address book, we search for an empty string ''. Mon, 23 Jun 2008 08:24:42 +0000 https://bugs.horde.org/ticket/6796#t46727 Reverted the "fix"...and I'm currently hitting a wall regarding how to fix this cleanly. Mon, 23 Jun 2008 17:20:13 +0000 https://bugs.horde.org/ticket/6796#t46735 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/turba/lib/Driver.php?r1=1.202&r2=1.203&ty=u http://cvs.horde.org/diff.php/turba/lib/Driver/sql.php?r1=1.116&r2=1.117&ty=u Sat, 05 Jul 2008 14:06:46 +0000 https://bugs.horde.org/ticket/6796#t47234 Committed a slightly different version and this seems to fix the original issue and does not cause any issues with listing complete address books using the empty string. Will wait for some feeback/other testing before merging. Sat, 05 Jul 2008 14:12:20 +0000 https://bugs.horde.org/ticket/6796#t47237 Merging, this has been operating fine for me for the past two days. Sun, 06 Jul 2008 16:22:37 +0000 https://bugs.horde.org/ticket/6796#t47257