Message cache update flags cannot handle imap ranges

"Empty folder" operation gives the list of message indices i

Fri, 18 Apr 2008 12:36:09 +0000

"Empty folder" operation gives the list of message indices in the form understood by the imap protocol to mean "from to first to the end", that is, "1:*". Everything else in IMP seems to handle this OK, but updateFlags function in lib/IMAP/MessageCache.php doesn't - it apparently excpects a list of explicite message id numbers, not a one-membered list that contains an IMAP range. Result: the messages are flagged as deleted on the server, but not in cache, so IMP shows them without overstrike in the mailbox index. (However, "Hide deleted", "Purge deleted" etc. do work.) The attached patch adds the imap range "1:*" as a special case to the _loadUIDs argument $uids - if $uids has "1:*" as its first element, we retrieve all the UIDs we have in cache. I'm not sure whether this actually resolves the problem; seems to work for me this far...

Go one step further - I removed all passing of the '1:*' str

Sat, 19 Apr 2008 18:52:06 +0000

Go one step further - I removed all passing of the '1:*' string internally since it is not valid input for our functions. We are going to eventually need the full list of indices anyway, so we pass that list instead.

Changes have been made in Git (master): commit 5c8d6d360327

Wed, 06 Sep 2017 08:17:45 +0000

Changes have been made in Git (master): commit 5c8d6d36032768579cd2dc3763e198cd95044cc8 Author: bertrand Gugger Date: Mon Jan 30 15:03:27 2006 +0000 Add the Wilink rule (#6623) git-svn-id: https://svn.php.net/repository/pear/packages/Text_Wiki/trunk@206123 c90b9560-bf6c-de11-be94-00142212c4b1 Text/Wiki/Mediawiki.php | 2 +- Text/Wiki/Parse/Mediawiki/Wikilink.php | 74 ++++++++++++++++++++++++++++++++++ 2 files changed, 75 insertions(+), 1 deletion(-) http://github.com/horde/horde/commit/5c8d6d36032768579cd2dc3763e198cd95044cc8

Changes have been made in Git (master): commit 388176385b6a

Wed, 06 Sep 2017 08:17:46 +0000

Changes have been made in Git (master): commit 388176385b6a0d9e34bd0368000cdbd44d9cf79f Author: bertrand Gugger Date: Mon Jan 30 15:09:08 2006 +0000 Spaces around headings are not mandatory (#6623) git-svn-id: https://svn.php.net/repository/pear/packages/Text_Wiki/trunk@206127 c90b9560-bf6c-de11-be94-00142212c4b1 Text/Wiki/Parse/Mediawiki/Heading.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) http://github.com/horde/horde/commit/388176385b6a0d9e34bd0368000cdbd44d9cf79f

Changes have been made in Git (master): commit 46697cedb549

Wed, 06 Sep 2017 08:17:47 +0000

Changes have been made in Git (master): commit 46697cedb549044ae56ceed8d5976f08ddbe9cff Author: bertrand Gugger Date: Fri Feb 3 19:45:27 2006 +0000 #6623: missing quantifier '?' git-svn-id: https://svn.php.net/repository/pear/packages/Text_Wiki/trunk@206374 c90b9560-bf6c-de11-be94-00142212c4b1 Text/Wiki/Parse/Mediawiki/Wikilink.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) http://github.com/horde/horde/commit/46697cedb549044ae56ceed8d5976f08ddbe9cff

Changes have been made in Git (master): commit d798cb847202

Wed, 06 Sep 2017 08:17:47 +0000

Changes have been made in Git (master): commit d798cb84720222af705c34408ad9b3f15aa02a1e Author: bertrand Gugger Date: Fri Feb 3 19:47:02 2006 +0000 A space is enough to delimitate a heading, no need for a linefeed (#6623) git-svn-id: https://svn.php.net/repository/pear/packages/Text_Wiki/trunk@206375 c90b9560-bf6c-de11-be94-00142212c4b1 Text/Wiki/Parse/Mediawiki/Heading.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) http://github.com/horde/horde/commit/d798cb84720222af705c34408ad9b3f15aa02a1e