Fri, 10 Apr 2026 10:04:41 +0000 https://bugs.horde.org/ticket/6500 hasSubGallery - Remove Ansel_Gallery::hasChildren - is used only in gallery delete page and hasSubGalleries does the same, but has cashed values. - We don't need to cache the hasChildren data in Shares as this data is retreived only when a gallery is removed and in the update script. - Some more places to get check of sub-galleries. Wed, 19 Mar 2008 10:09:24 +0000 https://bugs.horde.org/ticket/6500#t43986 Why are you removing the conditional check for $gallery->hasSubGallery() in places like in the various *stack.php classes? Wouldn't that prevent an unnecessary call to Ansel_Storage::listGalleries() with it's larger SELECT along with avoiding the (admittedly small amount) of extra code in that if block? Wed, 19 Mar 2008 14:25:53 +0000 https://bugs.horde.org/ticket/6500#t43995 ? The patch adds them. There is no sub-gallery check in *stack Wed, 19 Mar 2008 14:28:23 +0000 https://bugs.horde.org/ticket/6500#t43997 Doh. I reversed the order of the files in my compare tool :) Sorry - and thanks! Wed, 19 Mar 2008 14:30:01 +0000 https://bugs.horde.org/ticket/6500#t43998 Committed, but changed hasSubGallery() to hasSubGalleries() Thanks! Wed, 19 Mar 2008 14:49:24 +0000 https://bugs.horde.org/ticket/6500#t44000 > Committed, but changed hasSubGallery() to hasSubGalleries() Not a huge deal - but why? Seems like you want to return true if the singular or plural is true, not just the plural. :) Wed, 19 Mar 2008 14:51:21 +0000 https://bugs.horde.org/ticket/6500#t44001 Since the galley attribute is has_subgalleries I changed it to match more closely. Plus, the way I had originally named these type of methods was with "children" so I wanted to kind of stay close to that semantically :) Wed, 19 Mar 2008 15:05:41 +0000 https://bugs.horde.org/ticket/6500#t44002