Fri, 10 Apr 2026 19:28:26 +0000 https://bugs.horde.org/ticket/6394 Freebusy.php: Fix wrong return value Hello together, attached patch fixes a wrong return value which should be a string instead of an array (returned by listEvents()). Cheers, Thomas Fri, 07 Mar 2008 11:00:22 +0000 https://bugs.horde.org/ticket/6394#t43531 Thanks! Slightly fixed and commited to CVS. Fri, 07 Mar 2008 12:41:34 +0000 https://bugs.horde.org/ticket/6394#t43539 > Thanks! Slightly fixed and commited to CVS. Something still looks wrong: The return value of generate() is listed as "string". If all is fine the function returns the $vCal variable which is of type Horde_iCalendar, right? What about either returning Horde_iCalendar or "false" if the calendar is empty? Fri, 07 Mar 2008 12:59:47 +0000 https://bugs.horde.org/ticket/6394#t43541 Another option would be to remove the empty check completely: I'm currently debugging why I'm getting an error from Kolab's "pfb.php" for an empty calendar folder. The reason is the empty check -> no calendar.pvc file get's created. Guess the code is in there to clean up removed calendars, though this was the wrong fix IMHO. I'll investigate further... Fri, 07 Mar 2008 13:07:09 +0000 https://bugs.horde.org/ticket/6394#t43544 > Another option would be to remove the empty check completely: > > I'm currently debugging why I'm getting an error from Kolab's > "pfb.php" for an empty calendar folder. The reason is the empty check > -> no calendar.pvc file get's created. > > Guess the code is in there to clean up removed calendars, though this > was the wrong fix IMHO. I'll investigate further... > I believe generate() should always return a vCal object. If it is empty and the upstream code has a problem with that, I'll need to deal with that upstream. In CVS. Tue, 11 Mar 2008 10:20:50 +0000 https://bugs.horde.org/ticket/6394#t43698 > I believe generate() should always return a vCal object. If it is > empty and the upstream code has a problem with that, I'll need to > deal with that upstream. In CVS. Looks good, that's the proper solution. Thanks. Tue, 11 Mar 2008 13:29:23 +0000 https://bugs.horde.org/ticket/6394#t43704