Creating filter rules with null test values

Judging from bugs 3313 and 5392, it sounds like users should

Thu, 16 Aug 2007 18:33:19 +0000

Judging from bugs 3313 and 5392, it sounds like users shouldn't be able to create a filter rule such as "Subject contains ". But there doesn't appear to be anything preventing this. In both 1.0.1 and in 1.1.3, users can leave the value field empty and save the filter. We've had several users blow away their inboxes because they inadvertently set up filter rules such as this. Is there supposed to be something preventing them from saving a rule with an empty test value? -Robin

Definitely sounds like a good idea to me. I've added code to

Wed, 22 Aug 2007 03:11:39 +0000

Definitely sounds like a good idea to me. I've added code to 1.2-cvs (aka HEAD currently) to reject saving of a rule if there are empty conditions in it.

No good. This also rejects "exists" tests...

Wed, 22 Aug 2007 03:44:51 +0000

No good. This also rejects "exists" tests...

And "doesn't exist" tests.

Wed, 22 Aug 2007 03:46:57 +0000

And "doesn't exist" tests.

Tweaked.

Wed, 22 Aug 2007 04:13:20 +0000

Tweaked.