Fri, 10 Apr 2026 19:46:52 +0000 https://bugs.horde.org/ticket/5387 Empty mailbox doesn't When trash folder is not used, "empty folder" button doesn't empty the folder. It marks all messages as deleted and says "Emptied all messages from %s." It should either say "Marked all messages in %s as deleted" or it should expunge the folder to actually empty it. Mon, 21 May 2007 21:42:10 +0000 https://bugs.horde.org/ticket/5387#t33303 IMP_Message::emptyMailbox() uses IMP_Message::delete() which we use for *any* message deletion. Mon, 21 May 2007 22:04:30 +0000 https://bugs.horde.org/ticket/5387#t33309 I think, having used this for a few weeks now, that I like the old behavior better, and it is more consistent with how we document the feature. If we keep the new behavior, then I -think- the problem is that calling IMP_Message::delete() with array('1:*') for $indices works for the IMAP deletion, but that the message cache isn't updated properly (I don't think IMP_MailboxCache groks 1:*). I don't use a trash folder, and using empty mailbox the first time has no apparent effect - but if I purge the folder afterwards, then it is emptied. Sat, 16 Jun 2007 00:09:01 +0000 https://bugs.horde.org/ticket/5387#t34253 Having thought about this five more seconds, I realized that the changed behavior made "empty folder" pretty non-useful from the Folders screen, if you're not using a trash folder. So I changed it to use the trash folder if there is a trash folder, but otherwise to go ahead and delete the messages immediately. Sat, 16 Jun 2007 00:17:05 +0000 https://bugs.horde.org/ticket/5387#t34257 I just tried this from the mailbox view, and it marked all messages deleted, but didn't immediately expunge... Thu, 21 Jun 2007 20:39:52 +0000 https://bugs.horde.org/ticket/5387#t34548 This sounds an awful lot like the problem I've been describing in email.. http://marc.info/?l=imp&m=120587110731837&w=2 http://marc.info/?l=imp&m=120498692231289&w=2 All the user feedback we've received thus far in testing is that "Empty folder" should delete and expunge, and currently neither Head nor IMP 4.2 RC2 or 3 do that. Our rollout team concurs. Even if "empty folder" is only supposed to delete and not expunge, it doesn't do that well either. The "empty folder" icon present in mailbox view, will tell you that the folder's been emptied, but then doesn't refresh the message list. It tells you it's deleted everything, but unless you refresh the screen, the messages don't even appear to be marked deleted. Based on the comments in this ticket, and our own experience, I don't think this issue is actually resolved. Tue, 18 Mar 2008 20:51:10 +0000 https://bugs.horde.org/ticket/5387#t43976 Does this fix the issue? http://lists.horde.org/archives/cvs/Week-of-Mon-20080317/076363.html Wed, 19 Mar 2008 06:42:34 +0000 https://bugs.horde.org/ticket/5387#t43983 Yay! http://lists.horde.org/archives/cvs/Week-of-Mon-20080317/076363.html fixes the issue. Thanks so much! Wed, 19 Mar 2008 14:12:09 +0000 https://bugs.horde.org/ticket/5387#t43993 Actually, I spoke to soon. It's still broken if a user has a use_trash preference, if use_trash is turned off (e.g. when someone has tried "use_trash" and then decided they didn't like it and turned it off...) | liamr | imp | use_trash | 0 | I'm guessing that "use_trash" set to 0 breaks the empy($trash_folder) check in the patch.. + $trash_folder = ($GLOBALS['prefs']->getValue('use_trash')) ? IMP::folderPref($GLOBALS['prefs']->getValue('trash_folder'), true) : null; + if (empty($trash_folder) || ($trash_folder == $mbox)) { Wed, 19 Mar 2008 14:27:19 +0000 https://bugs.horde.org/ticket/5387#t43996 0 should still evaluate to false there, so the trash folder should be null, so the check should be fine (if I'm reading it in context correctly). Can you put in some variable checks (var_dump or such) to check all that? Wed, 19 Mar 2008 18:04:41 +0000 https://bugs.horde.org/ticket/5387#t44015 Furthermore, what you describe is exactly what I do to test -- I use trash and only turn it off when I am doing dev work/bug tracking. And it works fine for me. The logic is "expunge all messages if not using trash or if in the trash mailbox." Or, put a different way, "only expunge if either there is no trash mailbox defined or if the current mailbox is the trash mailbox." Wed, 19 Mar 2008 18:09:18 +0000 https://bugs.horde.org/ticket/5387#t44016 Weird. I can't replicate it anymore. Ok, I guess I revert to my original statement that the patch has fixed the issue. Wed, 19 Mar 2008 18:26:50 +0000 https://bugs.horde.org/ticket/5387#t44018 Excellent, thanks. Wed, 19 Mar 2008 18:29:03 +0000 https://bugs.horde.org/ticket/5387#t44020