Fri, 10 Apr 2026 14:10:55 +0000 https://bugs.horde.org/ticket/5355 Fix for PHP4 reference handling Hello together, while developing the new Kolab driver for kronolith I found out that the reference handling in PHP4 is somewhat messed up. I've written a small test case to demonstrate the problem. Attached you'll find a fix for Kronolith and one for Horde_Share. Cheers, Thomas Mon, 14 May 2007 13:33:27 +0000 https://bugs.horde.org/ticket/5355#t33057 Fix for kronolith Mon, 14 May 2007 13:33:52 +0000 https://bugs.horde.org/ticket/5355#t33058 Fix for Horde_Share. Mon, 14 May 2007 13:34:22 +0000 https://bugs.horde.org/ticket/5355#t33059 I know you probably have, but did you test the Share change? There have been problems in the past with assigning a reference to a static variable in PHP 4. It may work if the static variable is an array, instead of overwriting the static directly. But if you have: static $foo; ... $foo = &new Bar(); Then the reference won't take. Also, this should only matter if, in the constructor, the class creates a child object that needs to be assigned by reference. So I think a lot of the places you added it in Kronolith are unnecessary. Can you add new patches that only add the & where it fixes a problem we're seeing? Thanks! Mon, 14 May 2007 19:28:24 +0000 https://bugs.horde.org/ticket/5355#t33063 Hello Chuck, > I know you probably have, but did you test the Share change? There > have been problems in the past with assigning a reference to a static > variable in PHP 4. It may work if the static variable is an array, > instead of overwriting the static directly. But if you have: > > static $foo; > ... > $foo = &new Bar(); > > Then the reference won't take. Wow, I just modified my example code and it broke. Thanks for pointing this out. The Horde_Share::singleton() code uses an array $shares, so it should be ok. Works so far without problems here. I've changed this as the new kolab share handler uses internal references between parent and child objects. > Also, this should only matter if, in the constructor, the class > creates a child object that needs to be assigned by reference. So I > think a lot of the places you added it in Kronolith are unnecessary. > Can you add new patches that only add the & where it fixes a problem > we're seeing? Well, the new kronolith kolab driver uses an internal wrapper to switch between the old and the new backend. This wrapper has a back-reference to the Kronolith_Driver object, which breaks without the change. The problem is you think its working, but you almost won't notice it and then strange bugs occur when a variable inside the real driver object changed and you still have an old copy of that object floating around. If you want to you can skip the "FBview.php" and "Kronolith.php" part of the patch as it was only changed to make the fix complete. I've just checked all static variables in Kronolith, looks good to me. I'm still wondering a bit about Kronolith_Driver::factory(). The comment states it should return a concrete instance of a driver, but as far as I can see it always creates a new instance. Also take a look at lib/Scheduler/kronolith.php. It creates a global driver object and then creates another two. Is that supposed to happen? Cheers, Thomas Tue, 15 May 2007 08:01:47 +0000 https://bugs.horde.org/ticket/5355#t33072 > I'm still wondering a bit about Kronolith_Driver::factory(). The > comment states it should return a concrete instance of a driver, but > as far as I can see it always creates a new instance. That's the behavior of a factory - it turns a string into a concrete object. Probably not the clearest behavior in the world but it's behaving correctly. > Also take a look at lib/Scheduler/kronolith.php. It creates a global driver > object and then creates another two. Is that supposed to happen? Doubtful. :) Thu, 17 May 2007 19:47:46 +0000 https://bugs.horde.org/ticket/5355#t33141 The fixes are committed now, thanks. Thu, 17 May 2007 19:49:14 +0000 https://bugs.horde.org/ticket/5355#t33144 I've done another round of reference fixing and here is the result. We didn't want to commit it directly to CVS, so please have a look. I hope it's the last patch in this area :-) Fri, 25 May 2007 09:58:54 +0000 https://bugs.horde.org/ticket/5355#t33460 Committed, thanks. Fri, 25 May 2007 16:42:56 +0000 https://bugs.horde.org/ticket/5355#t33505