Fri, 10 Apr 2026 10:04:37 +0000 https://bugs.horde.org/ticket/5207 Make the deliverables billable/non-billable It would be nice if the deliverables or Job types can be marked as Billable and Non-billable. Currently employees are given the option to mark a specific time as billable/non-billable. This may not be ideal, because the lower level employees may mark some of the non-billable(Eg. Employee Leave, Vacation, etc..) hours as billable. This will also increase the security of the application. Wed, 04 Apr 2007 05:49:19 +0000 https://bugs.horde.org/ticket/5207#t31093 As I have mentioned in the mailing list, Our team is trying to enhance hermes. As a first step, we would like to fix some of the requests here. I would like to know which of the following is the best strategy : Is it good to make the deliverables billable/non-billable or make the job type billable/non-billable? Please provide your inputs. Thu, 04 Oct 2007 13:13:45 +0000 https://bugs.horde.org/ticket/5207#t37404 I think it'd be more manageable to make job types billable/not billable, since deliverables are rather arbitrary as they can be tasks, whatever. So it'd take a lot of metadata and tracking. Not that it'd be impossible if that's what people need. Fri, 05 Oct 2007 02:26:59 +0000 https://bugs.horde.org/ticket/5207#t37425 With reference to the following post http://lists.horde.org/archives/dev/Week-of-Mon-20070917/022030.html I am submitting the first patch for adding billable/non-billable option in Jobtype Fri, 12 Oct 2007 09:30:32 +0000 https://bugs.horde.org/ticket/5207#t37627 A few style comments, I didn't look at the actual code yet: - Please create unified diffs - Don't comment code out, if has to go, delete it - Don't keep debug code in the patches. - The applications' sql files only contain the sql statements necessary for the initial installation. If you have to change the sql schema, simply do so in the base sql file, and provide upgrade sql statements in separate sql scripts that go into scripts/upgrades/2007-01-01-some_script_name.sql Fri, 12 Oct 2007 11:39:15 +0000 https://bugs.horde.org/ticket/5207#t37630 Sorry for my mistake and thanks for your valuable suggestions. Please find the attached patch file ,in this patch i tried to implement all of your suggestions. I have also attached (as a new comment) 2007-10-12_add_jobtype_billable.sql file it contains sql queries for upgrade. Fri, 12 Oct 2007 13:01:08 +0000 https://bugs.horde.org/ticket/5207#t37634 Please find the attachment 2007-10-12_add_jobtype_billable.sql file ( likely to put on scripts/upgrades ) Fri, 12 Oct 2007 13:05:26 +0000 https://bugs.horde.org/ticket/5207#t37635 Much better, thanks. There are still a few nits, sorry for being picky: - The sql upgrade script is for mysql. Please see docs/CODING_STANDARDS for preferred sql syntax, and other upgrade scripts for examples. - The default value of a "boolean" field type is already "false", no need to explicitly specify that. - Use "empty($var)" instead of "$var == false" especially for configuration values. - Add the end of the patch to Driver/sql.php you casted the rate to int and the billable flag to float, it should be the opposite. Fri, 12 Oct 2007 13:22:14 +0000 https://bugs.horde.org/ticket/5207#t37638 Thanks I will post the patch after resolving sql compatibility issues and other stuffs related to coding. Fri, 12 Oct 2007 14:34:39 +0000 https://bugs.horde.org/ticket/5207#t37650 With reference your previous message ,I have made changes in code and attached a new patch file for your reference. In case sql upgrade file,I have changed it to prefered sql syntax and it will be attached in next message. Mon, 15 Oct 2007 13:08:39 +0000 https://bugs.horde.org/ticket/5207#t37674 Please find the the attached sql upgrade file 2007-10-15_add_jobtype_billable.sql Mon, 15 Oct 2007 13:10:17 +0000 https://bugs.horde.org/ticket/5207#t37678 Tweaked (mostly whitespace), changed the default for job types to be billable, and committed. Your patch didn't include the changes to conf.xml though, can you please provide them? Wed, 17 Oct 2007 17:53:18 +0000 https://bugs.horde.org/ticket/5207#t37771 Thanks For ensuring backward compatibility, we made changes based on the configuration variable $conf[time][choose_ifbillable],ie if this variable is enabled ,time slice is billable/non-billable ,otherwise jobtype can be billable/non-billable. I would like to know which changes are need to be done on conf.xml? Thu, 18 Oct 2007 05:25:52 +0000 https://bugs.horde.org/ticket/5207#t37825 Nevermind, I thought that configuration setting didn't exist yet. Thu, 18 Oct 2007 08:59:10 +0000 https://bugs.horde.org/ticket/5207#t37832