Thu, 09 Apr 2026 23:21:09 +0000 https://bugs.horde.org/ticket/5086 foreach with references in the tasklists.inc template The list of shares that is used within the tasklists.inc template is a list of references in my case (kolab share driver). The use of the two foreach loops within the templates mixes up these refernces and once I edit a share I end up with one shares being listed twice and other shares missing. In case the share array should really be an array of references the attached patch would fix the problematic foreach loops. In case the share list should not provide object references, the driver would probably need to be modified accordingly. Thu, 08 Mar 2007 07:53:18 +0000 https://bugs.horde.org/ticket/5086#t30112 s/the driver would/the share driver would/ Thu, 08 Mar 2007 07:54:17 +0000 https://bugs.horde.org/ticket/5086#t30113 This doesn't make a lot of sense to me. Even if it's an array of references, they're not changed in either loop, and you should be able to loop through it more than once. Is this a difference between the kolab and datatree drivers, or a PHP version thing? Thu, 08 Mar 2007 20:18:30 +0000 https://bugs.horde.org/ticket/5086#t30169 The issue that I had matched what is described here: http://www.php.net/manual/en/control-structures.foreach.php#66000 and changing the way the iteration works in that template fixed the problem for me. But I don't know if that is dependant on the PHP version. I am using PHP-5.1.6 on the development machine. I can do further testing with the PHP version and also compare to the datatree driver if that is required. Fri, 09 Mar 2007 08:38:03 +0000 https://bugs.horde.org/ticket/5086#t30194 But this loop doesn't even use references. Fri, 09 Mar 2007 11:24:38 +0000 https://bugs.horde.org/ticket/5086#t30197 The problem still exists for me but I still need to investigate the correct source for the error and try to construct an example. I'll reopen it once I know more. Fri, 13 Apr 2007 15:26:40 +0000 https://bugs.horde.org/ticket/5086#t31599 Here's the root of the problem: Let's say you have an array of references to Horde_Share objects named $shares. When you now process the array via foreach ($shares as $key => $share) { $share->get('name') } it creates a copy of the share object if you access it like this. Here's the proper fix: foreach(array_keys($shares) as $id) { $shares[$id]->get('name'); } That fixed the share renaming (among other reference fixes) in mnemo, which are going to be submitted soon. It's also the way Turba accesses the shares. Fri, 01 Jun 2007 09:05:41 +0000 https://bugs.horde.org/ticket/5086#t33713 > foreach ($shares as $key => $share) { > $share->get('name') > } btw: PHP5 supports references in foreach, but that's out of the question right now for Horde. Using PHP5 it can be written like this: foreach ($shares as $key => &$share) { $share->get('name') } Fri, 01 Jun 2007 09:09:13 +0000 https://bugs.horde.org/ticket/5086#t33714 > btw: PHP5 supports references in foreach, but that's out of the > question right now for Horde. Using PHP5 it can be written like this: With PHP 5 objects aren't copied unless you clone them, so none of this junk is necessary... Fri, 01 Jun 2007 14:38:49 +0000 https://bugs.horde.org/ticket/5086#t33730 I still don't understand how this results in not getting the right values for read-only share access, but I've committed it for now. Fri, 01 Jun 2007 14:55:42 +0000 https://bugs.horde.org/ticket/5086#t33733