Wrong timezone used in linked attachment notifications

In link attachment downloaded notifications emails, the "Att

Wed, 01 Nov 2006 22:52:13 +0000

In link attachment downloaded notifications emails, the "Attachment Date:" is set to GMT-10 instead of GMT-5 on our system in the EST timezone. Using a real example, when the receipient of the link attachment downloaded the attachment, the sender received the link attachment download notification email with: Attachment date: Wed, 1 Nov 2006 03:37:12 -0500 when the correct time the attachment was uploaded was actually: Wed, 1 Nov 2006 08:37:12 -0500. The problem appears to be caused by the use of gmmktime in horde/imp/lib/Compose.php. It uses: $ts = gmmktime(); $fullpath = sprintf('%s/%s/%d', IMP_VFS_LINK_ATTACH_PATH, $auth, $ts); So this generates a URL in email sent to the receipient like so: https://server/attachment.php?u=&t=&f= horde/imp/attachment.php then uses the value of t= as the date: time_stamp = Util::getFormData('t'); [snip] $msg->setContents(String::wrap(sprintf(_("Your linked attachment has been downloaded by at least one user.\n\nAttachment name: %s\nAtt achment date: %s\n\nClick on the following link to permanently delete the attachment:\n%s"), $file_name, date('r', $time_stamp), Util::addParamete r(Horde::selfUrl(true, false, true), 'd', $id)))); On my system, gmmktime() returns seconds since epoch + 5 hours and time() returns second since epoch. So I used this patch: [root@puma imp]# diff attachment.php attachment.php.orig 47,49d46 < // generate timestamp that shows correct timezone for notification email < $time_stamp_display = $time_stamp - intval(date('Z', $time_stamp)); < 113c110 < $msg->setContents(String::wrap(sprintf(_("Your linked attachment has been downloaded by at least one user.\n\nAttachment name: %s\nAttachment date: %s\n\nClick on the following link to permanently delete the attachment:\n%s"), $file_name, date('r', $time_stamp_display), Util::addParameter(Horde::selfUrl(true, false, true), 'd', $id)))); --- > $msg->setContents(String::wrap(sprintf(_("Your linked attachment has been downloaded by at least one user.\n\nAttachment name: %s\nAttachment date: %s\n\nClick on the following link to permanently delete the attachment:\n%s"), $file_name, date('r', $time_stamp), Util::addParameter(Horde::selfUrl(true, false, true), 'd', $id)))); I'm using Horde 3.1.4, IMP 4.1.3 on RHEL 4 AS U4. This has PHP version 4.3.9.

Please, PLEASE provide meaningful ticket summaries.

Wed, 01 Nov 2006 23:20:38 +0000

Please, PLEASE provide meaningful ticket summaries.

I meant to say: "On my system, gmmktime() returns seconds

Mon, 06 Nov 2006 04:30:16 +0000

I meant to say: "On my system, gmmktime() returns seconds since epoch - 5 hours"

So is there a reason not to just use time instead of gmmktim

Thu, 16 Nov 2006 05:20:55 +0000

So is there a reason not to just use time instead of gmmktime in Compose.php? And can you please upload your patch as an attachment, generated as a unified diff? Thanks.

> So is there a reason not to just use time instead of gmmkt

Thu, 16 Nov 2006 12:46:39 +0000

> So is there a reason not to just use time instead of gmmktime in > Compose.php? There is no difference because it returns the timestamp, so that doesn't fix the problem. I "fixed" this locally already but with some weird results that I still need to look into.

> I "fixed" this locally already but with some weird results

Fri, 26 Oct 2007 03:39:32 +0000

> I "fixed" this locally already but with some weird results that I still need to look into. What's the status of this?

No progress.

Fri, 26 Oct 2007 10:50:06 +0000

No progress.

Fixed in 4.2.0 - looks like we were missing a call to NLS::s

Tue, 13 Nov 2007 01:55:31 +0000

Fixed in 4.2.0 - looks like we were missing a call to NLS::setTimeZone().