spellcheck on Safari

Once completed spell checking a message on the Safari browse

Fri, 29 Sep 2006 14:03:18 +0000

Once completed spell checking a message on the Safari browser, clicking on "Resume Editing" erases the entire message.

Confirmed

Sat, 30 Sep 2006 01:06:46 +0000

Confirmed

Unfortunately, I don't have access to a mac.

Sat, 30 Sep 2006 20:58:55 +0000

Unfortunately, I don't have access to a mac.

We found that simplifying the targetValue function in imp/j

Thu, 05 Oct 2006 14:25:38 +0000

We found that simplifying the targetValue function in imp/js/SpellChecker.js from: targetValue: function(value) { // Ensure we have the correct input. this.input = $(this.target); if (value) { if (typeof this.input.value == 'undefined') { this.input.innerHTML = value; } else { this.input.value = value; } } return (typeof this.input.value == 'undefined') ? this.input.innerHTML : this.input.value; }, to: targetValue: function(value) { if (value) { this.input.innerHTML = value; this.input.value = value; } return (typeof this.input.value == 'undefined') ? this.input.innerHTML : this.input.value; }, solved the problem for Safari without breaking any of the other browsers we tested.

Works for me. Committed, thanks.

Thu, 05 Oct 2006 18:43:34 +0000

Works for me. Committed, thanks.

We found a case in which our patch failed: Internet Explorer

Fri, 06 Oct 2006 20:11:26 +0000

We found a case in which our patch failed: Internet Explorer in HTML mode. We again simplified the targetValue function in imp/js/SpellChecker.js from: targetValue: function(value) { if (value) { this.input.innerHTML = value; this.input.value = value; } return (typeof this.input.value == 'undefined') ? this.input.innerHTML : this.input.value; }, to: targetValue: function(value) { if (value) { this.input.value = value; return; } return (typeof this.input.value == 'undefined') ? this.input.innerHTML : this.input.value; }, to correctly handle Internet Explorer in both plain text and HTML mode (Windows only), Firefox in both plain text and HTML mode (Windows and OS X), and Safari plain text mode (OS X).

Committed, thanks.

Sat, 07 Oct 2006 00:30:55 +0000

Committed, thanks.

Changes have been made in Git (master): commit d98056759724

Wed, 06 Sep 2017 08:17:25 +0000

Changes have been made in Git (master): commit d98056759724f8d5e94a98038f61f7177e823c5f Author: Paul M Jones Date: Mon May 30 13:37:47 2005 +0000 fixed bug 4474 to silence calls to htmlentities and htmlspecialchars so that errors about charsets don't pop up, per counsel from Jan at Horde. git-svn-id: https://svn.php.net/repository/pear/packages/Text_Wiki/trunk@187320 c90b9560-bf6c-de11-be94-00142212c4b1 Text/Wiki/Render/Xhtml.php | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) http://github.com/horde/horde/commit/d98056759724f8d5e94a98038f61f7177e823c5f