Don't dim signatures in quoted text

With today's dimsignature changes in HEAD, my unquoted signa

Wed, 16 Aug 2006 21:28:39 +0000

With today's dimsignature changes in HEAD, my unquoted signature is no longer dim. Quoted signatures are dim though.

Your issue is bogus. The algorithim for dimming signatures

Thu, 17 Aug 2006 14:34:53 +0000

Your issue is bogus. The algorithim for dimming signatures recently changed from dimming everything below the first signature line to dimming everything below the last signature line. It has nothing to do with quoted vs. unquoted. The new algorithim makes more sense because it won't result in an entire message being dimmed if the signature appears on top. Not to start a holy war, but it is definitely preferred etiquette to quote under previous text, so the user's signature should *always* appear at the bottom of the message. However, your message does bring up another issue - namely, we shouldn't be dimming signatures in quoted text anyway if just for the simple fact we start mixing closed/unclosed div/span tags and the page won't render properly. i.e., in this case, pseudocode looks like this:

HTML Signature

This is a severe limitation with the current Text_Filter scheme since each filter doesn't (and can't) know if a previous filter has inserted div/span tags that may intersect the current text. Yuck. Possible solution - we have to do signature dimming in the highlight quote filter. This would ensure we weren't setting a signature span across quoted div's.

As far as I can tell, we need to combine some filter algorit

Tue, 26 Dec 2006 06:04:09 +0000

As far as I can tell, we need to combine some filter algorithms into a single call or else we will run into issues with improperly closed tags. But this can't be done until Horde 4 since it will break BC.

Changes have been made in Git for this ticket: Bug #4299: F

Tue, 13 Oct 2009 00:47:22 +0000

Changes have been made in Git for this ticket: Bug #4299: Fix dimming signatures when mixed with quoted text http://git.horde.org/diff.php/framework/Text_Filter/lib/Horde/Text/Filter/Dimsignature.php?rt=horde-git&r1=a4821dba3cebdd907a36635ce22b9569ce35e32b&r2=85505a2a7397637aacfb9150f1b17d1a57618a7c http://git.horde.org/diff.php/framework/Text_Filter/package.xml?rt=horde-git&r1=0a1dd0cd19b9adc33aea4d4f137b4d6b0aef4e8f&r2=85505a2a7397637aacfb9150f1b17d1a57618a7c