Sun, 05 Apr 2026 20:30:18 +0000 https://bugs.horde.org/ticket/4263 A splitted share driver In order to have better kolab support it would be nice to split the current Share module so that it supports different driver types. The attached patches are only a first draft to get some comments on the structure of the code. Please criticize everything you feel is incorrect or has an inappropriate structure. I'm not really a horde expert so I assume that I probably violated some of the concepts of the horde framework. Thanks for any comments! Tue, 08 Aug 2006 10:03:06 +0000 https://bugs.horde.org/ticket/4263#t22788 Modified share configuration and removed kolab hooks. Tue, 08 Aug 2006 10:05:06 +0000 https://bugs.horde.org/ticket/4263#t22790 Kronolith, nag, mnemo and turba use the htmlspecialchars() function to encode the share id, while using rawurlencode in the java snippet that provides the list of available shares. Since the share ids in the kolab driver include a "/" character the resulting ids did not match. Tue, 08 Aug 2006 10:08:18 +0000 https://bugs.horde.org/ticket/4263#t22791 Just wondering how well using Kolab as a storage backend for shares will scale. I know really nothing about Kolab or using IMAP as a datastore so to speak, just curious. For example, in one installation I have dedicated datatree tables for storing Ansel galleries and images...the horde_datatree_ansel table has well over 20000 entries alone, and the matching attributes table obviously has *much* more than this. Tue, 08 Aug 2006 15:41:54 +0000 https://bugs.horde.org/ticket/4263#t22799 Ahem, no, that wouldn't scale well :) On the other hand having a specific kolab share driver is not so much about supporting horde apps like ansel. It is mainly centered towards turba, mnemo,nag and kronolith. The reason for suggesting a specific kolab driver is the fact that kolab is based on this IMAP-centric model and IMAP is the storage backend used for all kolab groupware information. So the original Kolab driver tries to bridge between the IMAP information and the datatree storage and constantly syncs from one to the other. And this actually never really worked. So having this specific share driver helps with kolab, but it will not be the most efficient choice for having large image galleries in an e-mail based storage system. Tue, 08 Aug 2006 16:04:25 +0000 https://bugs.horde.org/ticket/4263#t22800 > Ahem, no, that wouldn't scale well :) > > On the other hand having a specific kolab share driver is not so much > about supporting horde apps like ansel. It is mainly centered towards > turba, mnemo,nag and kronolith. Then I guess in addition to these changes, we will also need to implement configuration options that allow per-application share backend selection? Tue, 08 Aug 2006 16:37:00 +0000 https://bugs.horde.org/ticket/4263#t22804 Chuck, can you take a look at the rawurlencode() stuff, I'll take care of the Share code? Tue, 08 Aug 2006 17:24:03 +0000 https://bugs.horde.org/ticket/4263#t22815 Done. I've deleted the patches that are now completely committed just to consolidate the ticket a bit. Fri, 15 Sep 2006 02:06:21 +0000 https://bugs.horde.org/ticket/4263#t23919 * framework_Share_Share.php-Kolab_Share_fix-20061115.patch Allows the Share system to use different driver types instead of just relying on the datatree system. Wed, 15 Nov 2006 12:51:36 +0000 https://bugs.horde.org/ticket/4263#t26074 * framework_Share_Share_datatree.php-Kolab_Share_fix-20061115 Provides the Share datatree driver. Wed, 15 Nov 2006 12:52:16 +0000 https://bugs.horde.org/ticket/4263#t26075 * framework_Share_Share_kolab.php-Kolab_Share_fix-20061115 Provides the Share kolab driver. Wed, 15 Nov 2006 12:53:01 +0000 https://bugs.horde.org/ticket/4263#t26076 * framework_Kolab_Kolab.php-Kolab_Share_fix-20061115.patch A patch to convert the Kolab driver to the new kolab share driver Wed, 15 Nov 2006 12:53:56 +0000 https://bugs.horde.org/ticket/4263#t26077 * horde_config-Kolab_Share_fix-20061115.patch Patches the horde package to work together with the new share driver. Wed, 15 Nov 2006 12:54:41 +0000 https://bugs.horde.org/ticket/4263#t26078 * turba-Kolab_Shares_fix-20061115.patch Patches the turba package to work together with the new share driver. Wed, 15 Nov 2006 12:55:14 +0000 https://bugs.horde.org/ticket/4263#t26079 Since I switched to Horde CVS now and fixed some minor bugs on the new share driver, I did prepare an updated patch set. Please remove the old patch files. Thanks! Wed, 15 Nov 2006 12:56:31 +0000 https://bugs.horde.org/ticket/4263#t26080 I cleaned it up but still didn't get it working. Attached is the current version, please be more strict with the coding standards in the future (indention, tabs, curly braces). Did you test your patch with a non-Kolab setup? Mon, 20 Nov 2006 15:18:06 +0000 https://bugs.horde.org/ticket/4263#t26389 > I cleaned it up but still didn't get it working. Attached is the > current version, please be more strict with the coding standards in > the future (indention, tabs, curly braces). Did you test your patch > with a non-Kolab setup? Sorry about the style problems. I should have given it a second pass. And I also did not check the datatree functionality for the latest version but only for the kolab server. Sorry again. I tried to fix these problems and attatched a new patch for the Share directory. I hope the datatree side of things is clean now. The kolab.php driver still carries some fixme's though these should not be functionaly but structural problems. Tue, 21 Nov 2006 08:03:57 +0000 https://bugs.horde.org/ticket/4263#t26432 What's the status of this one? If the patches are good we should get them committed so they don't go stale... Wed, 20 Dec 2006 21:05:28 +0000 https://bugs.horde.org/ticket/4263#t27637 Still on my todo list, but I won't mind if anyone else is audting and testing the patch. Wed, 20 Dec 2006 21:50:40 +0000 https://bugs.horde.org/ticket/4263#t27646 While I did not change anythin within the code itself (besides an added error check) I did update the patches to the newest Horde version. There were only problems with the Kolab package because of the updates during the Auth patch I submitted a while ago. So the current patch set should cleanly apply against Horde HEAD. I did split the patch to the "horde" package. This would allow to apply the patches in a two step procedure: 1) Splitting the Share driver by applying framework_Share-Kolab_Share_fix-20061220.patch and horde_config_conf.xml-Kolab_Share_fix-20061220.patch 2) Adapting the Kolab parts to the new Share driver (the other three patches) Step 1) would split the share driver and provide a "datatree" and a "kolab" driver. This step should actually have no effect on anything related to Shares (at least as long as one chooses the "datatree" driver). Once this split has been tested and there are no problems, one could apply the last three patches to adapt the Kolab specific code to the new driver. I would then provide instructions for the Kolab community how to test the new code. Maybe that helps. Thanks for your efforts! Wed, 20 Dec 2006 22:42:49 +0000 https://bugs.horde.org/ticket/4263#t27682 All of the patches except the actual Share drivers are committed now, and I'm debugging those now (there seem to be some subtle bugs that I haven't tracked down yet). Turba is going to need some more work because it uses stuff in Share that other Groupware apps don't, but that should be its own ticket at this point for cleaning up the vbook/shared address book stuff. Thu, 28 Dec 2006 22:52:50 +0000 https://bugs.horde.org/ticket/4263#t27847 This is committed now. Turba needs to either be brought back to the mainline Share code, or get some other indeterminate fixes. But everything else seems okay. Great work, Gunnar! Fri, 29 Dec 2006 04:02:40 +0000 https://bugs.horde.org/ticket/4263#t27853