Thu, 09 Apr 2026 19:17:33 +0000 https://bugs.horde.org/ticket/3966 Move duplicate code to build RDN into new method to simplify subclassing of LDAP driver In turba/lib/Driver/ldap.php the RDN of objects is currently assembled in two functions: _makeKey and _save (if an object is renamed). I suggest to move the code that builds the RDN from the attributes into a new method. With this change it becomes much easier to subclass the LDAP driver and to build your own custom DNs. Maintainance also becomes somewhat easier if no code is duplicated. I've attached a patch that introduces a new method called _makeRDN. The patch was created using the files from Turba 2.1.1 but should should apply against HEAD without problems. Mon, 22 May 2006 14:12:29 +0000 https://bugs.horde.org/ticket/3966#t20487 Makes sense. Committed to HEAD and FW_3. Thanks! Tue, 23 May 2006 17:40:26 +0000 https://bugs.horde.org/ticket/3966#t20546