6.0.0-alpha12
6/12/25

[#2897] _getHordeImageOb in images.php does not check if $img is valid before calling $img->loadString
Summary _getHordeImageOb in images.php does not check if $img is valid before calling $img->loadString
Queue IMP
Queue Version 4.0.4
Type Bug
State Resolved
Priority 2. Medium
Owners
Requester ted (at) impulse (dot) net
Created 10/31/2005 (7164 days ago)
Due
Updated 11/15/2006 (6784 days ago)
Assigned
Resolved 11/01/2005 (7163 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
11/15/2006 04:38:08 AM Michael Slusarz Comment #5 Reply to this comment
Looking at imp 4.0.5 and 4.13, this patch doesn't appear to have been
applied.  Was it decided that it wasn't necessary, or do I just need
to wait for the next update?
This was committed after 4.0.5 was released, but before 4.1.  See:

http://cvs.horde.org/diff.php?r1=1.56&r2=1.57&f=imp%2Flib%2FMIME%2FViewer%2Fimages.php
11/15/2006 03:41:31 AM bennettj (at) johnbennettservices (dot) com Comment #4 Reply to this comment
Actually, this error is due to your misconfiguration of the image
driver.  But we should do a check for error here so this will be
committed.
Looking at imp 4.0.5 and 4.13, this patch doesn't appear to have been 
applied.  Was it decided that it wasn't necessary, or do I just need 
to wait for the next update?



Thanks,



John
11/04/2005 10:32:21 PM frank (dot) richter (at) hrz (dot) tu-chemnitz (dot) de Comment #3 Reply to this comment
I'm curios - what's wrong with the MIME configuration?

Is it because GD doesn't support TIFF, but the default 
/imp/config/mime_drivers.php

contains    $mime_drivers['imp']['images']['inline'] = true;

for image/*



Thanks,

Frank
11/01/2005 03:06:43 AM Michael Slusarz Comment #2
State ⇒ Resolved
Reply to this comment
Actually, this error is due to your misconfiguration of the image 
driver.  But we should do a check for error here so this will be 
committed.
10/31/2005 10:19:42 PM ted (at) impulse (dot) net Comment #1
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ _getHordeImageOb in images.php does not check if $img is valid before calling $img->loadString
Queue ⇒ IMP
New Attachment: imp_images_php.diff Download
Reply to this comment
imp/lib/MIME/Viewer/images.php does not check the validity of the $img 
variable before calling loadString on it.  The patch provided adds 
this check.



I had an email that would cause a "Call to a member function on a 
non-object" error when imp tried to call a function on the 
non-existent $img.

Saved Queries