Recurring events when I delete a recurrence ALWAYS create an exception.

If you create a recurring event, for example for all days in

Mon, 07 Mar 2005 16:00:41 +0000

If you create a recurring event, for example for all days in this month, if I delete the recurrence for day 15 and click "Future" all is OK. But I select the same event and modify the end date again at 30 March the recurrence of the day 15 not appear because has a exception. I think we must add a exception only for the fisrt recurrence of the recurring event. POSIBLE FIX: diff -r1.1 deleventaction.php 38,40c38,43 < $event->addException(Util::getFormData('year'), < Util::getFormData('month'), < Util::getFormData('mday')); --- > if (mktime(0, 0, 0, $event->start->month, $event->start->mday, $event->start->year) == > mktime(0, 0, 0, Util::getFormData('month'), Util::getFormData('mday'), Util::getFormData('year'))) { > $event->addException(Util::getFormData('year'), > Util::getFormData('month'), > Util::getFormData('mday')); > }

It looks to me like that addException() call in the 'future'

Mon, 28 Mar 2005 19:57:50 +0000

It looks to me like that addException() call in the 'future' case was simply left over and shouldn't be there at all - please test what happens when you just remove it?

OK you can remove the event directly in the 'future' case li

Tue, 29 Mar 2005 08:52:57 +0000

OK you can remove the event directly in the 'future' case like this: diff deleventaction.php line 38 < $event->addException(Util::getFormData('year'), < Util::getFormData('month'), < Util::getFormData('mday')); --- > if (mktime(0, 0, 0, $event->start->month, $event->start->mday, $event->start->year) == > mktime(0, 0, 0, Util::getFormData('month'), Util::getFormData('mday'), Util::getFormData('year'))) { > $kronolith->deleteEvent($event->getID()); > } else > $event->save(); line 49 < if ($event->hasRecurType(KRONOLITH_RECUR_NONE) || Util::getFormData('all') || !$event->hasActiveRecurrence()) { --- > if (isset($event) && ($event->hasRecurType(KRONOLITH_RECUR_NONE) || Util::getFormData('all') || !$event->hasActiveRecurrence())) { Sebastian Calero.

1. Please use unified diffs and upload patches as attachment

Thu, 31 Mar 2005 04:16:34 +0000

1. Please use unified diffs and upload patches as attachments instead of pasting them. 2. I don't think that patch makes sense. Why wouldn't the hasActiveRecurrences() call catch the case you're talking about? I've committed a fix for what I've been able to reproduce.

1.- Sorry. 2.- I was mistaken in this point. I thought t

Thu, 31 Mar 2005 09:30:02 +0000

1.- Sorry. 2.- I was mistaken in this point. I thought the function 'hasActiveRecurrence' must to return only true if the event has more than ONE recurrence. Sorry again. Your patch seems optimal and I have already applied it. Greetings and thanks. Sebastian Calero.