Errors with new code to handle iCal export of categories/tags

There are two problems introduced with version 4.2.17. Th

Tue, 26 Sep 2017 10:24:18 +0000

There are two problems introduced with version 4.2.17. The first is very similar to bug #14698 and concerns the code change at https://github.com/horde/horde/commit/72560bfc1e01282cec6e9c8fdbdebfbe39a5809f#diff-c0ec275af3420bccfd7fe6f8de93f277 This code has got the right parathesis at the wrong spot as well and uses "$this->tags[0]" which is not correct. See #14698 for more details. The second problem is a different one but has also been introducted with version 4.2.17. It leads to error messages in the log file like this: HORDE [nag] PHP ERROR: Undefined offset: 0 [pid 11411 on line 1245 of "[...]/nag/lib/Task.php"] It seems that the "$priorityMap" might be missing an entry at index 0, i.e. "0 => 0,", but I'm not sure that adding a line to that effect around line 1239 of Task.php would be a proper fix because I don't understand what those magic values do.

Changes have been made in Git (FRAMEWORK_5_2): commit d97ca

Tue, 26 Sep 2017 13:36:13 +0000

Changes have been made in Git (FRAMEWORK_5_2): commit d97ca159549f2ab4342ce5f4b9cdaac1c6bfebb2 Author: Jan Schneider Date: Tue Sep 26 15:35:18 2017 +0200 [jan] Fix regression in exporting single tags to iCalendar CATEGORIES (Bug #14699). nag/docs/CHANGES | 2 ++ nag/lib/Task.php | 6 +----- nag/package.xml | 4 ++-- 3 files changed, 5 insertions(+), 7 deletions(-) http://github.com/horde/horde/commit/d97ca159549f2ab4342ce5f4b9cdaac1c6bfebb2

Changes have been made in Git (FRAMEWORK_5_2): commit e740a

Tue, 26 Sep 2017 13:36:14 +0000

Changes have been made in Git (FRAMEWORK_5_2): commit e740a718580ca392ae7d3a28da09e6b7e3219c75 Author: Jan Schneider Date: Tue Sep 26 15:35:54 2017 +0200 [jan] Fix notice when re-exporting tasks without priority (Bug #14699). nag/docs/CHANGES | 1 + nag/lib/Task.php | 1 + nag/package.xml | 2 ++ 3 files changed, 4 insertions(+) http://github.com/horde/horde/commit/e740a718580ca392ae7d3a28da09e6b7e3219c75

Changes have been made in Git (master): commit be530a444770

Tue, 26 Sep 2017 13:53:15 +0000

Changes have been made in Git (master): commit be530a444770eab6010ccac622472948c6504500 Author: Jan Schneider Date: Tue Sep 26 15:35:18 2017 +0200 [jan] Fix regression in exporting single tags to iCalendar CATEGORIES (Bug #14699). nag/lib/Task.php | 6 +----- nag/package.xml | 16 +++++++++++++++- 2 files changed, 16 insertions(+), 6 deletions(-) http://github.com/horde/horde/commit/be530a444770eab6010ccac622472948c6504500

Changes have been made in Git (master): commit 0f3486d073f6

Tue, 26 Sep 2017 13:53:15 +0000

Changes have been made in Git (master): commit 0f3486d073f69c4036ead2fb22a7ba744cac3ad8 Author: Jan Schneider Date: Tue Sep 26 15:35:54 2017 +0200 [jan] Fix notice when re-exporting tasks without priority (Bug #14699). nag/docs/CHANGES | 9 +++++++++ nag/lib/Task.php | 1 + 2 files changed, 10 insertions(+) http://github.com/horde/horde/commit/0f3486d073f69c4036ead2fb22a7ba744cac3ad8

Changes have been made in Git (FRAMEWORK_5_2): commit 4dbbd

Fri, 20 Oct 2017 20:34:03 +0000

Changes have been made in Git (FRAMEWORK_5_2): commit 4dbbd34f898605fb79bf46cb10f21edf859f3790 Author: Jan Schneider Date: Tue, 26 Sep 2017 15:35:18 +0200 [jan] Fix regression in exporting single tags to iCalendar CATEGORIES (Bug #14699). M docs/CHANGES M lib/Task.php M package.xml https://github.com/horde/nag/commit/4dbbd34f898605fb79bf46cb10f21edf859f3790

Changes have been made in Git (FRAMEWORK_5_2): commit 7162f

Fri, 20 Oct 2017 20:34:03 +0000

Changes have been made in Git (FRAMEWORK_5_2): commit 7162f4663299e2fe848f2c69a1f9e1e30f9b513f Author: Jan Schneider Date: Tue, 26 Sep 2017 15:35:54 +0200 [jan] Fix notice when re-exporting tasks without priority (Bug #14699). M docs/CHANGES M lib/Task.php M package.xml https://github.com/horde/nag/commit/7162f4663299e2fe848f2c69a1f9e1e30f9b513f