Handling bad VCARD format from the iPhone.

Configuration: horde and iOS contact are kept in sync using

Sat, 29 Jul 2017 05:30:28 +0000

Configuration: horde and iOS contact are kept in sync using with CardDAV. Horde is installed from the debian distribution (debian stretch). When adding contacts, the user may not select any "type" field for the telephone number, and there is no default. This breaks the VCARD format, see the attachment. The problematic line is the following: TEL;type=pref:+36303770746 This snipplet fixed this for me, by rewriting the "PREF" field to "CELL". This may not be the most elegant fix, bit it works for me. 2307d2306 < $no_more_fields=true; 2311,2313d2309 < if ($no_more_fields && $type==='PREF') { < $type='CELL'; < }

Sorry, I forgot to mention that the diff is for turba/lib/Dr

Sat, 29 Jul 2017 12:24:58 +0000

Sorry, I forgot to mention that the diff is for turba/lib/Driver.php > Configuration: horde and iOS contact are kept in sync using with CardDAV. > Horde is installed from the debian distribution (debian stretch). > > When adding contacts, the user may not select any "type" field for > the telephone number, and there is no default. This breaks the VCARD > format, see the attachment. > > The problematic line is the following: > TEL;type=pref:+36303770746 > > This snipplet fixed this for me, by rewriting the "PREF" field to "CELL". > This may not be the most elegant fix, bit it works for me. > > 2307d2306 > < $no_more_fields=true; > 2311,2313d2309 > < if ($no_more_fields && $type==='PREF') { > < $type='CELL'; > < } >

Changes have been made in Git (master): commit 8f551adb50f4

Thu, 03 Aug 2017 19:38:45 +0000

Changes have been made in Git (master): commit 8f551adb50f4d1d04e81a0bd1b6597f81b44533e Author: Jan Schneider Date: Thu Aug 3 21:26:41 2017 +0200 Add test which doesn't exhibit bug #14673 though. turba/test/Turba/Unit/ImportTest.php | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) http://github.com/horde/horde/commit/8f551adb50f4d1d04e81a0bd1b6597f81b44533e

Changes have been made in Git (master): commit 606eeaec2bfd

Thu, 03 Aug 2017 19:38:46 +0000

Changes have been made in Git (master): commit 606eeaec2bfddec095c078606d5ad482580fa1e0 Author: Jan Schneider Date: Thu Aug 3 21:33:31 2017 +0200 Catch all attributes that don't match exactly. Extend solution for bug #14301 to keep all email, phone, and address type attributes and try to store them to a different attribute of the same type, if the detected attribute doesn't map to an existing field in the backend. Bug: 14673 turba/docs/CHANGES | 2 ++ turba/lib/Driver.php | 38 +++++++++++++------- turba/lib/Object.php | 97 +++++++++++++++++++++++++++++----------------------- turba/package.xml | 2 ++ 4 files changed, 83 insertions(+), 56 deletions(-) http://github.com/horde/horde/commit/606eeaec2bfddec095c078606d5ad482580fa1e0

Since this is a major change in how we add contacts to the b

Thu, 03 Aug 2017 19:40:29 +0000

Since this is a major change in how we add contacts to the backend, I won't backport it for now. Maybe at some later point after it proved to not introduce any regressions.