Tickets :: [#14609] Resources are now considered as private

6.0.0-beta1

9/7/25

Summary	Resources are now considered as private
Queue	Kronolith
Queue Version	FRAMEWORK_5_2
Type	Bug
State	Resolved
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	heinz (at) htl-steyr (dot) ac (dot) at
Created	04/11/2017 (3071 days ago)
Due
Updated	10/20/2017 (2879 days ago)
Assigned	04/12/2017 (3070 days ago)
Resolved	04/12/2017 (3070 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

10/20/2017 08:34:42 PM	Git Commit	Comment #10	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit d724020d53e67ec6757357ffb8738fa4cfc908c7 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Thu, 13 Apr 2017 16:02:48 -0400 ~~Bug: 14609~~ Removed the wrong check. Only consider the resource_management permission when deciding if we can display the full title or not. M lib/Event/Resource/Sql.php https://github.com/horde/kronolith/commit/d724020d53e67ec6757357ffb8738fa4cfc908c7

10/20/2017 08:34:41 PM	Git Commit	Comment #9	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit 3c85acaf1dacd073ee4495423e9ecbeca4177dfc Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Wed, 12 Apr 2017 13:03:53 -0400 ~~Bug: 14609~~ Don't hide the reservee, only the title. It's reasonable to list the person reserving the resource, so someone knows who to contact about possible conflicts etc... M lib/Event/Resource/Sql.php https://github.com/horde/kronolith/commit/3c85acaf1dacd073ee4495423e9ecbeca4177dfc

04/13/2017 08:04:13 PM	Michael Rubinsky	Comment #8	Reply to this comment
I think that the full event title won't be shown to anyone because isPrivate() is always returning true Indeed. I removed the wrong check. Fixed now, thanks.

04/13/2017 08:03:43 PM	Git Commit	Comment #7	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit 4c2316af8caa2070756f83fb176dc51da80a3476 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Thu Apr 13 16:02:48 2017 -0400 ~~Bug: 14609~~ Removed the wrong check. Only consider the resource_management permission when deciding if we can display the full title or not. kronolith/lib/Event/Resource/Sql.php \| 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) http://github.com/horde/horde/commit/4c2316af8caa2070756f83fb176dc51da80a3476

04/12/2017 05:30:48 PM	heinz (at) htl-steyr (dot) ac (dot) at	Comment #6	Reply to this comment
This was the original intent. The full event title was only shown to users with "Resource Administration" permissions. However, I think it's reasonable to show the reservee's name and hide the event title instead. I think that the full event title won't be shown to anyone because isPrivate() is always returning true (because resources don't have any share entry in the dadabase) and the code (strlen($this->title) ? sprintf('%s %s', $this->title, $reservee) : sprintf(_("[Unnamed event] %s"), $reservee)) is never executed.

04/12/2017 05:09:02 PM	Michael Rubinsky	State ⇒ Resolved

04/12/2017 05:08:43 PM	Git Commit	Comment #5	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit 36f9dd4b796b9d21805e0f1ca919d4bce26465d6 Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Wed Apr 12 13:03:53 2017 -0400 ~~Bug: 14609~~ Don't hide the reservee, only the title. It's reasonable to list the person reserving the resource, so someone knows who to contact about possible conflicts etc... kronolith/lib/Event/Resource/Sql.php \| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) http://github.com/horde/horde/commit/36f9dd4b796b9d21805e0f1ca919d4bce26465d6

04/12/2017 05:02:33 PM	Michael Rubinsky	Comment #4 State ⇒ Assigned Assigned to Michael Rubinsky	Reply to this comment
This was the original intent. The full event title was only shown to users with "Resource Administration" permissions. However, I think it's reasonable to show the reservee's name and hide the event title instead.

04/12/2017 04:41:37 PM	heinz (at) htl-steyr (dot) ac (dot) at	Comment #3	Reply to this comment
getTitle() of the Resource class is checking $this->isPrivate($user) If true (private) is returned (and that is now the case for all resources) the resource title is set to "busy" behavior until now: the event title (using the resource) and the reserver (reserved by: ...) were displayed maybe the resource itself sould now have a private field in its properties

04/12/2017 03:32:19 PM	Michael Rubinsky	Comment #2 State ⇒ Feedback	Reply to this comment
I don't see any issue with resource functionality in current release. Can you please explain exactly what you are seeing, and what you expect to see?

04/11/2017 12:40:03 PM	heinz (at) htl-steyr (dot) ac (dot) at	Comment #1 Priority ⇒ 1. Low State ⇒ Unconfirmed Patch ⇒ No Milestone ⇒ Queue ⇒ Kronolith Summary ⇒ Resources are now considered as private Type ⇒ Bug	Reply to this comment
After updating kronolith the resources are all considered private. The reason is the change in the solved ~~ticket 14568~~ with commit a32314ab7ee34c05d2915206ad8525efdd1e6032 function isPrivate() of Kronolith_Event now checks READ with hasPermission(Horde_Perms::READ) hasPermission is retrieving the event's share since calendar resources are not listed in the share database all resources are now private