Tickets :: [#14579] Gollem not compatible with FTP passwords that contain an @

Summary	Gollem not compatible with FTP passwords that contain an @
Queue	Gollem
Queue Version	FRAMEWORK_5_1
Type	Bug
State	Not Reproducible
Priority	1. Low
Owners
Requester	aaronp (at) critd (dot) com
Created	02/14/2017 (3041 days ago)
Due
Updated	06/26/2017 (2909 days ago)
Assigned
Resolved	06/26/2017 (2909 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

06/26/2017 03:00:51 PM	aaronp (at) critd (dot) com	Comment #3	Reply to this comment
Cannot reproduce. Confirmed. This was definitely not working for me before, and is no longer an issue for me now. There must have been some sort of update in between then and now that has made this no longer a problem. Thanks for your consideration!

06/26/2017 12:27:28 PM	Jan Schneider	Comment #2 State ⇒ Not Reproducible	Reply to this comment
Cannot reproduce.

02/14/2017 05:23:38 PM	aaronp (at) critd (dot) com	Comment #1 Priority ⇒ 1. Low Patch ⇒ No Milestone ⇒ Queue ⇒ Gollem Summary ⇒ Gollem not compatible with FTP passwords that contain an @ Type ⇒ Bug State ⇒ Unconfirmed	Reply to this comment
This can be fixed by urlencode()ing the password first. E.g.: File: /usr/local/lib/php/Horde/Vfs/Ftp.php, line 202: $url .= $this->_params['username'] . ':' . urlencode($this->_params['password']) Although I suspect that other fields might also benefit from additional urlencode()ing. I can verify that this fix works for me.