htmlspecialchars() error in row.inc

I get lots of these messages logged in syslog when browsing

Thu, 24 Nov 2016 04:19:04 +0000

I get lots of these messages logged in syslog when browsing the addressbook on a horde-5.2.16 webmail installation (been like that on previous versions as well): [turba] PHP ERROR: htmlspecialchars() expects parameter 1 to be string, array given [pid 831 on line 85 of ".../turba/templates/browse/row.inc"] Looking at the code, I can't help but notice this line appears useless to me as the $shown_columns[$c] value is overwritten 6 lines below; please have a look at https://github.com/horde/horde/blob/master/turba/templates/browse/row.inc#L85 I commented out the line on my local installation with no visible regression whatsoever.

Changes have been made in Git (master): commit b7fb38591689

Thu, 24 Nov 2016 14:08:21 +0000

Changes have been made in Git (master): commit b7fb38591689a8ab1c5de380197fe357d803d76a Author: Jan Schneider Date: Thu Nov 24 15:06:53 2016 +0100 Remove left over from 10-years-old code (Bug #14521). turba/templates/browse/row.inc | 1 - 1 file changed, 1 deletion(-) http://github.com/horde/horde/commit/b7fb38591689a8ab1c5de380197fe357d803d76a

Changes have been made in Git (FRAMEWORK_5_2): commit 8e26a

Thu, 24 Nov 2016 14:10:04 +0000

Changes have been made in Git (FRAMEWORK_5_2): commit 8e26ad3989e2c78427994a137ec6b3192e97165e Author: Jan Schneider Date: Thu Nov 24 15:06:53 2016 +0100 Remove left over from 10-years-old code (Bug #14521). turba/templates/browse/row.inc | 1 - 1 file changed, 1 deletion(-) http://github.com/horde/horde/commit/8e26ad3989e2c78427994a137ec6b3192e97165e

Changes have been made in Git (FRAMEWORK_5_2): commit 841fd

Fri, 20 Oct 2017 20:34:52 +0000

Changes have been made in Git (FRAMEWORK_5_2): commit 841fd0c7a14613a0452cb816229d52c7568d6c9d Author: Jan Schneider Date: Thu, 24 Nov 2016 15:09:44 +0100 Remove left over from 10-years-old code (Bug #14521). M templates/browse/row.inc https://github.com/horde/turba/commit/841fd0c7a14613a0452cb816229d52c7568d6c9d