Tickets :: [#14521] htmlspecialchars() error in row.inc

6.0.0-beta1

7/29/25

Summary	htmlspecialchars() error in row.inc
Queue	Turba
Queue Version	Git master
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org
Requester	horde.wayne (at) ptaff (dot) ca
Created	11/24/2016 (3169 days ago)
Due
Updated	10/20/2017 (2839 days ago)
Assigned
Resolved	11/24/2016 (3169 days ago)
Milestone
Patch	No

10/20/2017 08:34:52 PM	Git Commit	Comment #4	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit 841fd0c7a14613a0452cb816229d52c7568d6c9d Author: Jan Schneider <jan@horde.org> Date: Thu, 24 Nov 2016 15:09:44 +0100 Remove left over from 10-years-old code (~~Bug #14521~~). M templates/browse/row.inc https://github.com/horde/turba/commit/841fd0c7a14613a0452cb816229d52c7568d6c9d

11/24/2016 02:10:04 PM	Git Commit	Comment #3	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit 8e26ad3989e2c78427994a137ec6b3192e97165e Author: Jan Schneider <jan@horde.org> Date: Thu Nov 24 15:06:53 2016 +0100 Remove left over from 10-years-old code (~~Bug #14521~~). turba/templates/browse/row.inc \| 1 - 1 file changed, 1 deletion(-) http://github.com/horde/horde/commit/8e26ad3989e2c78427994a137ec6b3192e97165e

11/24/2016 02:08:31 PM	Jan Schneider	Assigned to Jan Schneider State ⇒ Resolved

11/24/2016 02:08:21 PM	Git Commit	Comment #2	Reply to this comment
Changes have been made in Git (master): commit b7fb38591689a8ab1c5de380197fe357d803d76a Author: Jan Schneider <jan@horde.org> Date: Thu Nov 24 15:06:53 2016 +0100 Remove left over from 10-years-old code (~~Bug #14521~~). turba/templates/browse/row.inc \| 1 - 1 file changed, 1 deletion(-) http://github.com/horde/horde/commit/b7fb38591689a8ab1c5de380197fe357d803d76a

11/24/2016 04:19:04 AM	horde (dot) wayne (at) ptaff (dot) ca	Comment #1 Priority ⇒ 1. Low Patch ⇒ No Milestone ⇒ Queue ⇒ Turba Summary ⇒ htmlspecialchars() error in row.inc Type ⇒ Enhancement State ⇒ New	Reply to this comment
I get lots of these messages logged in syslog when browsing the addressbook on a horde-5.2.16 webmail installation (been like that on previous versions as well): [turba] PHP ERROR: htmlspecialchars() expects parameter 1 to be string, array given [pid 831 on line 85 of ".../turba/templates/browse/row.inc"] Looking at the code, I can't help but notice this line appears useless to me as the $shown_columns[$c] value is overwritten 6 lines below; please have a look at https://github.com/horde/horde/blob/master/turba/templates/browse/row.inc#L85 I commented out the line on my local installation with no visible regression whatsoever.