6.0.0-alpha12
6/7/25

[#14397] Ingo Vacation Setting Produces invalid .procmailrc
Summary Ingo Vacation Setting Produces invalid .procmailrc
Queue Ingo
Queue Version 3.2.10
Type Bug
State Resolved
Priority 1. Low
Owners mrubinsk (at) horde (dot) org
Requester canderson (at) foxtwo (dot) net
Created 06/12/2016 (3282 days ago)
Due
Updated 10/20/2017 (2787 days ago)
Assigned
Resolved 07/29/2016 (3235 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
10/20/2017 08:33:42 PM Git Commit Comment #4 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit 84ce5666e4d77b12f727249caff1dc1f7ac1887d
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Fri, 29 Jul 2016 11:44:00 -0400

Bug: 14397 Cannot specify the 'h' flag when using an action block.

  M lib/Script/Procmail/Recipe.php
  M test/Ingo/Unit/ProcmailTest.php

https://github.com/horde/ingo/commit/84ce5666e4d77b12f727249caff1dc1f7ac1887d
07/29/2016 04:45:29 PM Michael Rubinsky Assigned to Michael Rubinsky
State ⇒ Resolved
 
07/29/2016 03:45:29 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit 0db158e57b5c1f4a2552b5c8cabe329d61f8db0d
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Fri Jul 29 11:42:25 2016 -0400

     Bug: 14397 Cannot specify the 'h' flag when using an action block.

  ingo/lib/Script/Procmail/Recipe.php  | 2 +-
  ingo/test/Ingo/Unit/ProcmailTest.php | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

http://github.com/horde/horde/commit/0db158e57b5c1f4a2552b5c8cabe329d61f8db0d
07/29/2016 03:43:21 PM Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit 95ced913fd288ace6f0c08a3a6a438e690f8bb37
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date:   Fri Jul 29 11:42:25 2016 -0400

     Bug: 14397 Cannot specify the 'h' flag when using an action block.

  ingo/lib/Script/Procmail/Recipe.php  | 2 +-
  ingo/test/Ingo/Unit/ProcmailTest.php | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

http://github.com/horde/horde/commit/95ced913fd288ace6f0c08a3a6a438e690f8bb37
06/12/2016 07:49:27 PM canderson (at) foxtwo (dot) net Comment #1
Priority ⇒ 1. Low
Patch ⇒ No
Milestone ⇒
Queue ⇒ Ingo
Summary ⇒ Ingo Vacation Setting Produces invalid .procmailrc
Type ⇒ Bug
State ⇒ Unconfirmed
Reply to this comment
When enabling a vacation message with Ingo set up to use procmail, the 
resulting .procmailrc has an error that causes messages to bounce with 
the message:

procmail: Extraneous deliver-head flag ignored

Looking at the generated .procmailrc I see:

...
      :0 h
      SUBJECT=| formail -xSubject:

      :0 Whc: ${VACATION_DIR:-.}/vacation.lock
      * ? test $DATE -gt $START && test $END -gt $DATE
      {
        :0 Wh
...

According to the procmail instructions, an "h" is invalid when the 
action is to open braces {}. I made a n edit to 
/ingo/lib/Script/Procmail/Recipe.php to remove the "h" flag:

185c185
<                     '    :0 Wc: ${VACATION_DIR:-.}/vacation.lock';
---
                     '    :0 Whc: ${VACATION_DIR:-.}/vacation.lock';
It now works as expected. I haven't tested all combinations of 
settings, so I am unsure if that will break something else, but it 
does produce a valid file.

Saved Queries