Custom attributes values are not shown if type is string

After upgrading whups to 3.0.7 custom attribute values are b

Sun, 10 Apr 2016 11:39:46 +0000

After upgrading whups to 3.0.7 custom attribute values are blank in ticket history if they are of type string. In my existing sql storage the attribute values (in table whups_attributes) are stored as string (not json encoded) Prior upgrading the values were retrived and tried to decode by Horde_Serialize::unserialize Horde_Serialize::unserialize returned the provided string in case of a not JSON-coded argument. After upgrade json_decode (with JSON_BIGINT_AS_STRING option) is used in case of a string. json_decode is returning NULL if the argument isn't JSON-coded and so custom string attributes are not shown. I think, it's a side effect of ticket 14146

Changes have been made in Git (master): commit 3472b95bde31

Sun, 10 Apr 2016 22:53:42 +0000

Changes have been made in Git (master): commit 3472b95bde312d663fa44b38e6c8b32b4ae4412e Author: Michael J Rubinsky Date: Sun Apr 10 18:51:48 2016 -0400 Bug: 14326 Fix decoding custom_attributes. These can be json_encoded (which may contain large numeric strings such as phone numbers), or bare scalar values. whups/lib/Driver.php | 50 +++++++++++++++++++++++++++++++++++---------- whups/lib/Driver/Sql.php | 38 ++-------------------------------- 2 files changed, 42 insertions(+), 46 deletions(-) http://github.com/horde/horde/commit/3472b95bde312d663fa44b38e6c8b32b4ae4412e

Changes have been made in Git (FRAMEWORK_5_2): commit 414a5

Sun, 10 Apr 2016 22:55:11 +0000

Changes have been made in Git (FRAMEWORK_5_2): commit 414a561e1295df8083100df9c8a4ed31d8567208 Author: Michael J Rubinsky Date: Sun Apr 10 18:51:48 2016 -0400 Bug: 14326 Fix decoding custom_attributes. These can be json_encoded (which may contain large numeric strings such as phone numbers), or bare scalar values. whups/lib/Driver.php | 50 +++++++++++++++++++++++++++++++++++---------- whups/lib/Driver/Sql.php | 38 ++-------------------------------- 2 files changed, 42 insertions(+), 46 deletions(-) http://github.com/horde/horde/commit/414a561e1295df8083100df9c8a4ed31d8567208

Whups 3.0.8

Sun, 10 Apr 2016 22:55:50 +0000

Whups 3.0.8

Changes have been made in Git (FRAMEWORK_5_2): commit 1fb12

Fri, 20 Oct 2017 20:34:57 +0000

Changes have been made in Git (FRAMEWORK_5_2): commit 1fb12bbfad843093c1b23b5ab39e42d08e700855 Author: Michael J Rubinsky Date: Sun, 10 Apr 2016 18:54:24 -0400 Bug: 14326 Fix decoding custom_attributes. These can be json_encoded (which may contain large numeric strings such as phone numbers), or bare scalar values. M lib/Driver.php M lib/Driver/Sql.php https://github.com/horde/whups/commit/1fb12bbfad843093c1b23b5ab39e42d08e700855