Tickets :: [#14196] Kolab driver: Nag's view tabs (All tasks, Incomplete tasks, Future tasks, Completed tasks) not rendered correctly

6.0.0-beta1

7/9/25

Summary	Kolab driver: Nag's view tabs (All tasks, Incomplete tasks, Future tasks, Completed tasks) not rendered correctly
Queue	Kolab
Type	Bug
State	Resolved
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	mike.gabriel (at) das-netzwerkteam (dot) de
Created	12/15/2015 (3494 days ago)
Due
Updated	12/29/2015 (3480 days ago)
Assigned	12/17/2015 (3492 days ago)
Resolved	12/29/2015 (3480 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	Yes

12/29/2015 04:44:07 AM	Michael Rubinsky	Comment #6 Assigned to Michael Rubinsky Taken from Michael J Rubinsky <mrubinsk@horde.org> Taken from Thomas Jarosch State ⇒ Resolved	Reply to this comment
Committed, thanks!

12/29/2015 04:43:40 AM	Git Commit	Comment #5	Reply to this comment
Changes have been made in Git (master): commit c02522fed6f33e1e306d5c5b4a8c1136989af87d Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de> Date: Mon Dec 28 23:39:27 2015 -0500 ~~Bug: 14196~~ Fix displaying tab filters in Kolab driver. Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org> nag/lib/Driver/Kolab.php \| 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) http://github.com/horde/horde/commit/c02522fed6f33e1e306d5c5b4a8c1136989af87d

12/29/2015 04:40:48 AM	Git Commit	Comment #4	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit 1197a222a96fe7e3c193dfc5031f2cefe20a314f Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de> Date: Mon Dec 28 23:39:27 2015 -0500 ~~Bug: 14196~~ Fix displaying tab filters in Kolab driver. Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org> nag/lib/Driver/Kolab.php \| 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) http://github.com/horde/horde/commit/1197a222a96fe7e3c193dfc5031f2cefe20a314f

12/17/2015 03:42:32 PM	Michael Rubinsky	Comment #3 Assigned to Michael J Rubinsky <mrubinsk@horde.org> State ⇒ Assigned Assigned to Thomas Jarosch	Reply to this comment
I believe something like this was resolved in Git previously, but need to verify.

12/16/2015 11:18:24 PM	Michael Rubinsky	Comment #2 Version ⇒ Queue ⇒ Kolab Priority ⇒ 1. Low	Reply to this comment
Moving to Kolab queue.

12/15/2015 07:18:52 PM	mike (dot) gabriel (at) das-netzwerkteam (dot) de	Comment #1 Priority ⇒ 2. Medium State ⇒ Unconfirmed New Attachment: 1002_nag-kolab-correctly-retrieve-tasklists-regarding-completion-state.patch Patch ⇒ Yes Milestone ⇒ Queue ⇒ Nag Summary ⇒ Kolab driver: Nag's view tabs (All tasks, Incomplete tasks, Future tasks, Completed tasks) not rendered correctly Type ⇒ Bug	Reply to this comment
I use Nag_Driver_Kolab as storage backend for tasks. Without the attached patch, Nag is not able to retrieve tasklists based on the completion flag (or other flags). The different tasklist tabs (when using the Kolab driver) always show _all_ tasks, although they should show what the tab title says, e.g. "All tasks", "Incomplete tasks", "Future tasks", "Completed tasks". This patch fixes the issue. The issue is caused through nested loops (foreach, switch) and wrong usage of the continue statement. See here for details: http://php.net/manual/en/control-structures.continue.php#96945