6.0.0-alpha12
6/8/25

[#13819] Filter Drag and drop dosen't update the filter activate/deactivate button after change of position
Summary Filter Drag and drop dosen't update the filter activate/deactivate button after change of position
Queue Ingo
Queue Version 3.2.3
Type Bug
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester pouyan.azari (at) uni-wuerzburg (dot) de
Created 01/21/2015 (3791 days ago)
Due
Updated 02/24/2015 (3757 days ago)
Assigned
Resolved 01/23/2015 (3789 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
02/24/2015 07:13:12 AM Git Commit Comment #6 Reply to this comment
Changes have been made in Git (master):

commit af9d5041df23f0bec606a54d4d305510b86193a3
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Mon Feb 23 22:24:47 2015 -0700

     Revert "[mms] Rate-limit filters drag/drop changes to prevent 
race conditions (Bug #13819)."

     This reverts commit c521c26a78f9d75d45a07a4069edb67843a5408a.

     Not needed anymore - race-conditions have been fixed by accessing rules
     by UIDs instead of filter position

  ingo/docs/CHANGES                             |    2 --
  ingo/js/filters.js                            |   18 ------------------
  ingo/package.xml                              |    1 -
  ingo/templates/basic/filters/filters.html.php |    4 ----
  ingo/themes/default/screen.css                |   13 -------------
  5 files changed, 0 insertions(+), 38 deletions(-)

http://github.com/horde/horde/commit/af9d5041df23f0bec606a54d4d305510b86193a3
01/23/2015 05:36:42 AM Git Commit Comment #5 Reply to this comment
Changes have been made in Git (master):

commit c521c26a78f9d75d45a07a4069edb67843a5408a
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Thu Jan 22 22:29:40 2015 -0700

     [mms] Rate-limit filters drag/drop changes to prevent race 
conditions (Bug #13819).

     Conflicts:
             ingo/docs/CHANGES
             ingo/package.xml

  ingo/docs/CHANGES                             |    2 ++
  ingo/js/filters.js                            |    6 ++++++
  ingo/package.xml                              |    5 ++++-
  ingo/templates/basic/filters/filters.html.php |    4 ++++
  ingo/themes/default/screen.css                |   13 +++++++++++++
  5 files changed, 29 insertions(+), 1 deletions(-)

http://github.com/horde/horde/commit/c521c26a78f9d75d45a07a4069edb67843a5408a
01/23/2015 05:30:10 AM Michael Slusarz Comment #4
Assigned to Michael Slusarz
State ⇒ Resolved
Reply to this comment
Ingo 3.2.4
01/23/2015 05:29:57 AM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit 06016c750f2249f5ea87b2a63c97655cf1567f68
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Thu Jan 22 22:29:40 2015 -0700

     [mms] Rate-limit filters drag/drop changes to prevent race 
conditions (Bug #13819).

  ingo/docs/CHANGES                             |    2 ++
  ingo/js/filters.js                            |    6 ++++++
  ingo/package.xml                              |    2 ++
  ingo/templates/basic/filters/filters.html.php |    4 ++++
  ingo/themes/default/screen.css                |   13 +++++++++++++
  5 files changed, 27 insertions(+), 0 deletions(-)

http://github.com/horde/horde/commit/06016c750f2249f5ea87b2a63c97655cf1567f68
01/21/2015 12:59:23 PM vidal (dot) carro (at) spamina (dot) com Comment #2 Reply to this comment
After drag and drop filter to sort them, activate and deactivate 
buttons are not updated. As an example I move the Blacklist Filter 
over Whitelist Filter and click on deactivate. It deactives the 
Whitelist filter which was up there before and not the Blacklist 
which I clicked.

Browser (Firefox 35,Linux)
   I have seen something similar when you move some rules and you 
after logout and login again, some rules disappear. Debuging I have 
seen in DB (table ingo_rules) that the rules that do not appear have 
the same value that others in the rule_order field.

   Likely for that it is deactivating the wrong rule.
01/21/2015 09:06:29 AM pouyan (dot) azari (at) uni-wuerzburg (dot) de Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Filter Drag and drop dosen't update the filter activate/deactivate button after change of position
Queue ⇒ Ingo
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Reply to this comment
After drag and drop filter to sort them, activate and deactivate 
buttons are not updated. As an example I move the Blacklist Filter 
over Whitelist Filter and click on deactivate. It deactives the 
Whitelist filter which was up there before and not the Blacklist which 
I clicked.

Browser (Firefox 35,Linux)

Saved Queries