Can't remove activesync device: JS error

services/prefs.php?app=horde&group=activesync On Chromium 3

Sat, 01 Nov 2014 13:52:08 +0000

services/prefs.php?app=horde&group=activesync On Chromium 33 It's impossible to remove a device. The JS log says Uncaught TypeError: Cannot read property 'id' of undefined Uncaught TypeError: Cannot call method 'startsWith' of null The HTML seems correct, so there must be a JS error somewhere

Cannot reproduce. Try updating Chrome.

Mon, 03 Nov 2014 15:14:34 +0000

Cannot reproduce. Try updating Chrome.

> Cannot reproduce. Try updating Chrome. Just tried on Fire

Thu, 06 Nov 2014 21:06:22 +0000

> Cannot reproduce. Try updating Chrome. Just tried on Firefox. Same problem. I've cleared all caches and deleted all static files and still nothing... Which files is responsible for the JS on that page?

The JS specific to the activesync stuff is in horde/js/activ

Thu, 06 Nov 2014 22:43:03 +0000

The JS specific to the activesync stuff is in horde/js/activesyncprefs.js

> The JS specific to the activesync stuff is in horde/js/act

Thu, 06 Nov 2014 23:25:50 +0000

> The JS specific to the activesync stuff is in horde/js/activesyncprefs.js Thanks. I've checked the javascript and it can't work. $('removedevice').setValue(this.devices[id.substr(7)].id); id: remove_ABCD1234:my.user@domain.tld [id.substr(7): ABCD1234:my.user@domain.tld devices {ABCD1234} ABCD1234:my.user@domain.tld does not exist in devices It used to work, so some recent changes must have added the user after the id in the HTML code for the button.

Reformatting id = "remove_ABCD1234:my.user@domain.tld" id.

Thu, 06 Nov 2014 23:28:26 +0000

Reformatting id = "remove_ABCD1234:my.user@domain.tld" id.substr(7) = "ABCD1234:my.user@domain.tld" devices { ABCD1234 { id: ABCD1234 user:my.user@domain.tld } } "ABCD1234:my.user@domain.tld" does not exist in devices

And I should have started with that... This is on the user s

Thu, 06 Nov 2014 23:30:15 +0000

And I should have started with that... This is on the user side, not the admin side.

Still can't reproduce this. I don't have the username append

Fri, 07 Nov 2014 01:30:35 +0000

Still can't reproduce this. I don't have the username appended to the device id as you do. I have no idea where that is coming from. Does the device list show the username as part of the device id also? The html for the device list and the buttons is built in horde/templates/activesync/device_table.html.php - where you can clearly see it is using only the device name.

You don't have a activesync_device_modify hook set, do you?

Fri, 07 Nov 2014 01:35:16 +0000

You don't have a activesync_device_modify hook set, do you?

> horde/templates/activesync/device_table.html.php - where y

Fri, 07 Nov 2014 08:27:31 +0000

> horde/templates/activesync/device_table.html.php - where you can > clearly see it is using only the device name. Only in master. In the 5.2 branch, the user is appended. https://github.com/horde/horde/blob/FRAMEWORK_5_2/horde/templates/activesync/device_table.html.php " id="remove_id . ':' . $d->user ?>" />
That was to fix bug 13336, so that the delete button would delete the proper device+account association https://github.com/horde/horde/commit/01b26397a1668fa25e2849f6b3b4710678544bf8

Well, if you are not using master, then why did you select G

Fri, 07 Nov 2014 15:08:03 +0000

Well, if you are not using master, then why did you select Git master as the version in use? Are you using GIt master, FW_5_2, or pear?

> Well, if you are not using master, then why did you select

Fri, 07 Nov 2014 15:25:02 +0000

> Well, if you are not using master, then why did you select Git master > as the version in use? > > Are you using GIt master, FW_5_2, or pear? I'm not sure I did according to the ticket log, but if I did I've made a mistake. I'm using PEAR.

There is a drop down when you create the ticket to indicate

Fri, 07 Nov 2014 15:54:37 +0000

There is a drop down when you create the ticket to indicate the application version. I'll take a look again when I have time now that I know what version to look at.

My apologies, it looks like it was changed to master by Mich

Fri, 07 Nov 2014 15:55:56 +0000

My apologies, it looks like it was changed to master by Michael S. when he reassigned the ticket to the correct queue. Anyway, I'll take a look again when I have time.

Changes have been made in Git (master): commit e3c6d57fb64b

Sun, 09 Nov 2014 18:58:53 +0000

Changes have been made in Git (master): commit e3c6d57fb64bba712e60b964462e6786cbe67c67 Author: Michael J Rubinsky Date: Sun Nov 9 13:57:51 2014 -0500 Bug: 13657 Fix user activesync client actions. horde/lib/Prefs/Special/Activesync.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) http://github.com/horde/horde/commit/e3c6d57fb64bba712e60b964462e6786cbe67c67

Changes have been made in Git (FRAMEWORK_5_2): commit 6b544

Sun, 09 Nov 2014 19:02:01 +0000

Changes have been made in Git (FRAMEWORK_5_2): commit 6b54414787e96f6028bf36eb5d40d2d941fa640c Author: Michael J Rubinsky Date: Sun Nov 9 13:57:51 2014 -0500 Bug: 13657 Fix user activesync client actions. Conflicts: horde/lib/Prefs/Special/Activesync.php horde/lib/Prefs/Special/Activesync.php | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) http://github.com/horde/horde/commit/6b54414787e96f6028bf36eb5d40d2d941fa640c

Horde 5.2.3

Sun, 09 Nov 2014 19:05:16 +0000

Horde 5.2.3

> Horde 5.2.3 Thank you!

Sun, 09 Nov 2014 19:19:54 +0000

> Horde 5.2.3 Thank you!