Summary | Can't remove activesync device: JS error |
Queue | Horde Base |
Queue Version | 5.2.2 |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | mrubinsk (at) horde (dot) org |
Requester | software-horde (at) interfasys (dot) ch |
Created | 11/01/2014 (3904 days ago) |
Due | |
Updated | 11/09/2014 (3896 days ago) |
Assigned | 11/07/2014 (3898 days ago) |
Resolved | 11/09/2014 (3896 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Resolved
commit 6b54414787e96f6028bf36eb5d40d2d941fa640c
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Sun Nov 9 13:57:51 2014 -0500
Bug: 13657Fix user activesync client actions.Conflicts:
horde/lib/Prefs/Special/Activesync.php
horde/lib/Prefs/Special/Activesync.php | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/6b54414787e96f6028bf36eb5d40d2d941fa640c
commit e3c6d57fb64bba712e60b964462e6786cbe67c67
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Sun Nov 9 13:57:51 2014 -0500
Bug: 13657Fix user activesync client actions.horde/lib/Prefs/Special/Activesync.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/e3c6d57fb64bba712e60b964462e6786cbe67c67
when he reassigned the ticket to the correct queue.
Anyway, I'll take a look again when I have time.
Version ⇒ 5.2.2
State ⇒ Assigned
Assigned to Michael Rubinsky
application version.
I'll take a look again when I have time now that I know what version
to look at.
master as the version in use?
Are you using GIt master, FW_5_2, or pear?
a mistake.
I'm using PEAR.
as the version in use?
Are you using GIt master, FW_5_2, or pear?
clearly see it is using only the device name.
In the 5.2 branch, the user is appended.
https://github.com/horde/horde/blob/FRAMEWORK_5_2/horde/templates/activesync/device_table.html.php
<input class="horde-delete" type="button" value="<?php echo
_("Remove") ?>" id="remove_<?php echo $d->id . ':' . $d->user ?>"
/><br />
That was to fix
bug 13336, so that the delete button would delete theproper device+account association
https://github.com/horde/horde/commit/01b26397a1668fa25e2849f6b3b4710678544bf8
device id as you do. I have no idea where that is coming from. Does
the device list show the username as part of the device id also? The
html for the device list and the buttons is built in
horde/templates/activesync/device_table.html.php - where you can
clearly see it is using only the device name.
the admin side.
id = "remove_ABCD1234:my.user@domain.tld"
id.substr(7) = "ABCD1234:my.user@domain.tld"
devices {
ABCD1234 {
id: ABCD1234
user:my.user@domain.tld
}
}
"ABCD1234:my.user@domain.tld" does not exist in devices
I've checked the javascript and it can't work.
$('removedevice').setValue(this.devices[id.substr(7)].id);
id: remove_ABCD1234:my.user@domain.tld
[id.substr(7): ABCD1234:my.user@domain.tld
devices {ABCD1234}
ABCD1234:my.user@domain.tld does not exist in devices
It used to work, so some recent changes must have added the user after
the id in the HTML code for the button.
I've cleared all caches and deleted all static files and still nothing...
Which files is responsible for the JS on that page?
State ⇒ Feedback
Queue ⇒ Horde Base
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Summary ⇒ Can't remove activesync device: JS error
Type ⇒ Bug
Queue ⇒ IMP
On Chromium 33
It's impossible to remove a device.
The JS log says
Uncaught TypeError: Cannot read property 'id' of undefined
Uncaught TypeError: Cannot call method 'startsWith' of null
The HTML seems correct, so there must be a JS error somewhere
<input class="horde-delete" type="button" value="Remove"
id="remove_BBALPHA:user@domain.tld">