Summary | Server port missing in selfUrl |
Queue | Horde Framework Packages |
Queue Version | FRAMEWORK_5_1 |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | mrubinsk (at) horde (dot) org |
Requester | Jasper.Olbrich (at) students (dot) uni-marburg (dot) de |
Created | 09/16/2014 (3918 days ago) |
Due | |
Updated | 03/10/2015 (3743 days ago) |
Assigned | 03/10/2015 (3743 days ago) |
Resolved | 03/10/2015 (3743 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
commit 644b73b737a0ff4f2044d47304c9b57d328fe8d8
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Tue Mar 10 12:00:00 2015 -0400
Only clear the port when forcing SSL.
If using SSL_ONLY_LOGIN, any custom configured port should be taken
as the HTTP port since HTTPS is only used for login.
Bug: 13573framework/Core/lib/Horde.php | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/644b73b737a0ff4f2044d47304c9b57d328fe8d8
State ⇒ Assigned
The failing test is actually the opposite situation. The custom HTTP
port is lost. Fixing.
Assigned to Michael Rubinsky
State ⇒ Not A Bug
works as expected - with the exception that if $conf['use_ssl'] == 3
then the custom port is always ignored. Not quite sure if that's
intended or not....
using a different than the non-default port.
use HTTPS during login. If there is a non-standard port configured, it
makes sense in this context for it to be the HTTP port (since we are
not using HTTPS except during login). In this case, there really is no
way to configure a non-standard HTTPS port.
Closing since the existing tests pass and I cannot reproduce the behavior.
selfUrl works as expected - with the exception that if
$conf['use_ssl'] == 3 then the custom port is always ignored. Not
quite sure if that's intended or not....
a different than the non-default port.
commit c8bea045ea456518b6710acd6eb20b5446df978c
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Thu Feb 5 10:01:59 2015 -0500
Add passing tests for
Bug: 13573framework/Core/test/Horde/Core/UrlTest.php | 20 ++++++++++++++++++++
1 files changed, 20 insertions(+), 0 deletions(-)
http://github.com/horde/horde/commit/c8bea045ea456518b6710acd6eb20b5446df978c
works as expected - with the exception that if $conf['use_ssl'] == 3
then the custom port is always ignored. Not quite sure if that's
intended or not....
forms that contain the "Add" button use this URL
<!--a75c305b1c0a6022--><form method="post"
action="https://example.com/services/portal/edit.php#block">
with missing port. Maybe the reason is somewhere else, but I
definately see wrong behavior.
State ⇒ Feedback
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Queue ⇒ Horde Framework Packages
Summary ⇒ Server port missing in selfUrl
Type ⇒ Bug
Priority ⇒ 1. Low
I can't edit the portal page if horde is served on an non-standard
port. The "Add" buttons on services/portal/edit.php all lead to
https://example.com/services/portal/edit.php#block, even if Horde is
running fine on https://example.com:1234.
I tried both
$conf['server']['port'] = $_SERVER['SERVER_PORT'];
and
$conf['server']['port'] = 1234;
to no avail. I think the bug is in selfUrl() from Core/lib/Horde.php,
but I'm unsure how to fix.