Activesync: quoted replies are broken in half

Device: BlackBerry 10 In Summary, Horde does not understand

Sat, 12 Jul 2014 12:43:56 +0000

Device: BlackBerry 10 In Summary, Horde does not understand the structure of the message it gets to send and breaks it in half in an attempt to quote it. I've tried both the reply text at the top or at the bottom. It doesn't change anything. It's the same behaviour for both HTML and text emails. 1st message looks normal BODY1 SIG1 When I reply, the compose window looks like this BODY2 SIG2 -------------- HEADER1 BODY1 SIG1 But ater it's sent, the message looks like this: user@domain.tld wrote >BODY1 >SIG1 BODY2 SIG2 -------------- HEADER1 So the text of the reply is placed above everything else while the header is placed at the bottom. At the next reply, the message looks like this user@domain.tld wrote >user@domain.tld wrote >>BODY1 >>SIG1 >BODY2 >SIG2 >-------------- >HEADER1 >-------------- BODY3 SIG3 -------------- HEADER2 -------------- I've done the same test from the same client, but using gmail and replies look fine BODY3 SIG3 -------------- HEADER2 -------------- BODY2 SIG2 -------------- HEADER1 -------------- BODY1 SIG1 What I call the header looks like this: ----------------- From: Sent To: Subject: -----------------

Some background: Email reply and forwards in EAS are (usu

Sat, 12 Jul 2014 16:01:08 +0000

Some background: Email reply and forwards in EAS are (usually) handled via something called SMART_REPLY or SMART_FORWARD - where only the NEW text (the actual reply text of the email) is sent to the server. The server is then responsible for fetching the original email from the IMAP server and the parse out the needed originally text and append the reply text before sending. EAS assumes "top-posting" - it assumes all replies appear before the quoted text. SOME clients include what you call the [header] text in the text that it sends to the server, but some do not. Because of this, Horde adds it's own "quoted header" - the "On blah blah, so and so said this:" text in the appropriate place based on the user's preference for top/bottom posting. This can lead to strange placements and duplicate headers (the one the client sent and the one Horde adds). We can't "sniff" out if there is a header in the text already since there is not standard form for it to take. There are two options other than the current situation: 1) Never add a header on the Horde side. The down side is that if the user is "bottom-posting" the client provided header still appears at the bottom of the email and there is no header at the beginning of the quoted text. 2) Disallow bottom posting. This would avoid the problem above, but would force the use of a reply style that many feel is inappropriate. The small number of clients that don't explicitly add the reply header to the text will generate replies without any reply header (though the original message would still be quoted). I've thought about this on and off over the last year or so, and I think (2) is probably the best solution. This was the way EAS was designed to operate. What Horde is doing is just a weak attempt to work around that limitation. While I personally prefer bottom posting, I think for mobile/EAS use this seems like the best option. Any other voices want to chime in? > Device: BlackBerry 10 > In Summary, Horde does not understand the structure of the message it > gets to send and breaks it in half in an attempt to quote it. > I've tried both the reply text at the top or at the bottom. It > doesn't change anything. > It's the same behaviour for both HTML and text emails. > > 1st message looks normal > BODY1 > SIG1 > > When I reply, the compose window looks like this > BODY2 > SIG2 > -------------- > HEADER1 > BODY1 > SIG1 > > But ater it's sent, the message looks like this: > user@domain.tld wrote >> BODY1 >> SIG1 > BODY2 > SIG2 > -------------- > HEADER1 > > > So the text of the reply is placed above everything else while the > header is placed at the bottom. > > At the next reply, the message looks like this > user@domain.tld wrote >> user@domain.tld wrote >>> BODY1 >>> SIG1 >> BODY2 >> SIG2 >> -------------- >> HEADER1 >> -------------- > BODY3 > SIG3 > -------------- > HEADER2 > -------------- > > > I've done the same test from the same client, but using gmail and > replies look fine > BODY3 > SIG3 > -------------- > HEADER2 > -------------- > BODY2 > SIG2 > -------------- > HEADER1 > -------------- > BODY1 > SIG1 > > What I call the header looks like this: > ----------------- > From: > Sent > To: > Subject: > ----------------- >

FWIW, this is also what makes your other request for configu

Sat, 12 Jul 2014 16:06:58 +0000

FWIW, this is also what makes your other request for configurable signatures so messy to implement.

Changes have been made in Git (master): commit c0744f481b31

Thu, 24 Jul 2014 03:20:45 +0000

Changes have been made in Git (master): commit c0744f481b31b954f7fd6043b3e0b0730a48df52 Author: Michael J Rubinsky Date: Wed Jul 23 22:41:25 2014 -0400 Bug: 13355 Remove logic dealing with (broken) activesync_replyposition pref. framework/Core/lib/Horde/Core/ActiveSync/Mail.php | 28 +++----------------- horde/config/prefs.php | 11 +------- 2 files changed, 6 insertions(+), 33 deletions(-) http://github.com/horde/horde/commit/c0744f481b31b954f7fd6043b3e0b0730a48df52

Went ahead and removed the code that adds the reply text. Th

Thu, 24 Jul 2014 03:24:53 +0000

Went ahead and removed the code that adds the reply text. The pref that determined which one to use was ignored (probably got dropped at some point during 5.2 development) so that was removed as well.

> Went ahead and removed the code that adds the reply text.

Thu, 24 Jul 2014 10:15:30 +0000

> Went ahead and removed the code that adds the reply text. The pref > that determined which one to use was ignored (probably got dropped at > some point during 5.2 development) so that was removed as well. > Ah, I was wondering why that switch had no effect in my tests.. OK, I've just tested the commit and there is a discrepancy between the way HTML an text replies are being built. HTML replies look perfect now, but text replies only have the main message in quotes, the header preceding it isn't. On mobile devices, it makes sense to have replies at the top, but it will create some strange emails if people place their replies at the bottom when using the desktop. Thanks for the detailed explanation on the inner workings.

> HTML replies look perfect now, but text replies only hav

Thu, 24 Jul 2014 20:25:38 +0000

> HTML replies look perfect now, but text replies only have the main > message in quotes, the header preceding it isn't. Not sure what you mean by this. Typically the header wouldn't be quoted. Either way, this is 100% controlled by the client. Horde doesn't add/remove anything from the reply text and header sent from the client anymore. That's what was causing the trouble in the first place.

> >> HTML replies look perfect now, but text replies only h

Thu, 24 Jul 2014 22:41:58 +0000

> >> HTML replies look perfect now, but text replies only have the main >> message in quotes, the header preceding it isn't. > > Not sure what you mean by this. Typically the header wouldn't be > quoted. Either way, this is 100% controlled by the client. Horde > doesn't add/remove anything from the reply text and header sent from > the client anymore. That's what was causing the trouble in the first > place. I've found out why I get that mix of quoted and unquoted text. When the original message contains an attachment, the text of the original message is quoted using the > sign. If Horde is not touching the reply, then it must be a problem with the phone.