6.0.0-git
2021-01-18

[#13248] horde-remove-user-data bails out if groups are read-only
Summary horde-remove-user-data bails out if groups are read-only
Queue Horde Groupware
Queue Version 5.1.4
Type Bug
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester skhorde (at) smail (dot) inf (dot) fh-bonn-rhein-sieg (dot) de
Created 2014-06-05 (2419 days ago)
Due
Updated 2014-06-05 (2419 days ago)
Assigned
Resolved 2014-06-05 (2419 days ago)
Milestone
Patch Yes

History
2014-06-05 11:39:33 Jan Schneider Assigned to Jan Schneider
State ⇒ Resolved
 
2014-06-05 11:39:28 Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit 05cb8e07a0df57801bd06eb48c2ddc906b2064b9
Author: Jan Schneider <jan@horde.org>
Date:   Thu Jun 5 13:37:30 2014 +0200

     [jan] Don't try to write to read-only group backends when 
removing user data (skhorde@smail.inf.fh-bonn-rhein-sieg.de, Bug 
#13248).

  horde/docs/CHANGES        |    2 ++
  horde/lib/Application.php |   16 +++++++++-------
  horde/package.xml         |    4 ++--
  3 files changed, 13 insertions(+), 9 deletions(-)

http://github.com/horde/horde/commit/05cb8e07a0df57801bd06eb48c2ddc906b2064b9
2014-06-05 09:53:46 skhorde (at) smail (dot) inf (dot) fh-bonn-rhein-sieg (dot) de Comment #1
Type ⇒ Bug
State ⇒ Unconfirmed
Priority ⇒ 1. Low
Summary ⇒ horde-remove-user-data bails out if groups are read-only
Queue ⇒ Horde Groupware
Milestone ⇒
Patch ⇒ Yes
New Attachment: h5_removeUserData-from-ro-LDAP-Group.diff.bz2 Download
Reply to this comment
If you setup Horde to use LDAP groups (maybe any other as well), but 
does not allow write access, then you try to remove user data via 
horde-remove-user-data, the script fails with a fatal error from 
horde/lib/Application.php around line 154.

Attached patch skips the removal of group memberships if 
$GLOBALS['injector']->getInstance('Horde_Group') returns an object 
that is read-only, aka $groups->readOnly() returns true.

Saved Queries