Default Spam filter rule doesn't work with Sieve

Default rule "Spam filter" with options doesn't produce vali

Mon, 10 Feb 2014 16:15:58 +0000

Default rule "Spam filter" with options doesn't produce valid Sieve script. Steps to reproduce: 1) Configure Ingo to use Sieve backend. 2) Try to Save and Activate Spam filter rule Ingo outputs error message: Script not updated: There was an error activating the script. The driver said: ingo: line 10: error: unknown test 'No' (only reported once at first occurence). ingo: error: validation failed. ---- Lines 9-13 produced on spam filter activation: 9: # Spam Filter 10: if No strings specified { 11: fileinto "Spam"; 12: stop; 13: } As you can see there is "No strings specified" so the generated rule is invalid and thus cannot work. I suppose that correct Sieve rule my should be something like this: 9: # Spam Filter 10: if allof ( not header :comparator "i;ascii-casemap" :contains "X-Spam-Score" "-", header :value "gt" :comparator "i;ascii-numeric" "X-Spam-Score" ["5"] ) { 11: fileinto "Spam"; 12: stop; 13: }

Changes have been made in Git (master): commit a9354d98136c

Tue, 11 Feb 2014 15:45:16 +0000

Changes have been made in Git (master): commit a9354d98136c3eff3b9c28d6b90d5a91c87c6025 Author: Jan Schneider Date: Tue Feb 11 16:39:14 2014 +0100 [jan] Make spam level a required form field (Bug #12964). ingo/lib/Form/Spam.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) http://git.horde.org/horde-git/-/commit/a9354d98136c3eff3b9c28d6b90d5a91c87c6025

Changes have been made in Git (master): commit 8e231e632ed4

Tue, 11 Feb 2014 15:45:20 +0000

Changes have been made in Git (master): commit 8e231e632ed4565e43bd7e6e91b9c12bc80d26f3 Author: Jan Schneider Date: Tue Feb 11 16:41:47 2014 +0100 [jan] Make spam level a required form field (Bug #12964). Conflicts: ingo/docs/CHANGES ingo/package.xml ingo/docs/CHANGES | 1 + ingo/package.xml | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) http://git.horde.org/horde-git/-/commit/8e231e632ed4565e43bd7e6e91b9c12bc80d26f3

Changes have been made in Git (FRAMEWORK_5_1): commit 1bad3

Tue, 11 Feb 2014 15:48:09 +0000

Changes have been made in Git (FRAMEWORK_5_1): commit 1bad3071b057955153acd4437f7fac7c97ae320a Author: Jan Schneider Date: Tue Feb 11 16:39:14 2014 +0100 [jan] Make spam level a required form field (Bug #12964). ingo/lib/Form/Spam.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) http://git.horde.org/horde-git/-/commit/1bad3071b057955153acd4437f7fac7c97ae320a

Changes have been made in Git (FRAMEWORK_5_1): commit 9658b

Tue, 11 Feb 2014 15:48:11 +0000

Changes have been made in Git (FRAMEWORK_5_1): commit 9658b471d31304b22acb5078edd76995f24727cf Author: Jan Schneider Date: Tue Feb 11 16:41:47 2014 +0100 [jan] Make spam level a required form field (Bug #12964). ingo/docs/CHANGES | 1 + ingo/package.xml | 2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) http://git.horde.org/horde-git/-/commit/9658b471d31304b22acb5078edd76995f24727cf