Wrong Sieve implementation of "Do not send responses to bulk or list messages"

This script is generated, if you check "Do not send response

Mon, 27 Jan 2014 08:29:16 +0000

This script is generated, if you check "Do not send responses to bulk or list messages". 1: # Sieve Filter 2: # Generated by Ingo (http://www.horde.org/apps/ingo/) (01/27/2014, 09:23) 3: require ["vacation", "regex"]; 4: # Vacation 5: if allof ( not exists ["list-help", "list-unsubscribe", "list-subscribe", "list-owner", "list-post", "list-archive", "list-id", "Mailing-List"], not header :comparator "i;ascii-casemap" :is "Precedence" ["list", "bulk", "junk"], not header :comparator "i;ascii-casemap" :matches "To" "Multiple recipients of*" ) { 6: vacation :days 7 :addresses "/dev/null@example.com" :subject "Test" "Test 1"; 7: } RFC 5228 sec. 5.5 explains, that "All of the headers must exist or the test is false". Hence, if one of the enumerated headers is missing in the exists clause, e.g. "Mailing-List", the "not exists" is false. E.g. the messages of the Horde list to not contain a "Mailing-List" header. I would suggest to change the condition to: anyof ( not exists "list-help", not exists "list-unsubscribe", not exists "list-subscribe", ...

This patch makes the script works for one or more of the lis

Thu, 30 Jan 2014 09:01:32 +0000

This patch makes the script works for one or more of the list headers instead of all of them: --- ingo/lib/Script/Sieve.php.orig 2014-01-30 09:47:50.000000000 +0100 +++ ingo/lib/Script/Sieve.php 2014-01-30 09:52:16.000000000 +0100 @@ -337,4 +337,8 @@ $headers['Mailing-List'] = null; - $tmp = new Ingo_Script_Sieve_Test_Exists(array('headers' => implode("\n", array_keys($headers)))); + foreach($headers as $header => $dummy) { + $tmp = new Ingo_Script_Sieve_Test_Exists(array('headers' => $header)); $tests[] = new Ingo_Script_Sieve_Test_Not($tmp); + } +# $tmp = new Ingo_Script_Sieve_Test_Exists(array('headers' => implode("\n", array_keys($headers)))); +# $tests[] = new Ingo_Script_Sieve_Test_Not($tmp); $vals = array('headers' => 'Precedence',

Changes have been made in Git (FRAMEWORK_5_1): commit 7d713

Thu, 30 Jan 2014 19:50:20 +0000

Changes have been made in Git (FRAMEWORK_5_1): commit 7d71388506ef92c0413f77e609936584b39dfa0c Author: Michael M Slusarz Date: Thu Jan 30 12:49:10 2014 -0700 [mms] Fix sieve driver correctly identifying mailing list when determining whether to send vacation messages (Bug #12938; skhorde@smail.inf.fg-bonn-rhein-sieg.de). ingo/docs/CHANGES | 3 +++ ingo/lib/Script/Sieve.php | 7 +++++-- ingo/package.xml | 4 ++-- 3 files changed, 10 insertions(+), 4 deletions(-) http://git.horde.org/horde-git/-/commit/7d71388506ef92c0413f77e609936584b39dfa0c

Ingo 3.1.4.

Thu, 30 Jan 2014 19:52:34 +0000

Ingo 3.1.4.

Changes have been made in Git (master): commit d9a2b4bc7e28

Thu, 30 Jan 2014 19:53:39 +0000

Changes have been made in Git (master): commit d9a2b4bc7e28c6a87068b0878e5b9a8eae309bfe Author: Michael M Slusarz Date: Thu Jan 30 12:49:10 2014 -0700 [mms] Fix sieve driver correctly identifying mailing list when determining whether to send vacation messages (Bug #12938; skhorde@smail.inf.fg-bonn-rhein-sieg.de). Conflicts: ingo/docs/CHANGES ingo/package.xml ingo/docs/CHANGES | 9 +++++++++ ingo/lib/Script/Sieve.php | 7 +++++-- ingo/package.xml | 13 +++++++++++++ 3 files changed, 27 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/d9a2b4bc7e28c6a87068b0878e5b9a8eae309bfe