"BAD signature" message appears when verifying a PGP signed HTML message with attachment

Today I install a clean Horde Webmail 5.1.2, and all compone

Tue, 15 Oct 2013 11:18:49 +0000

Today I install a clean Horde Webmail 5.1.2, and all components are the latest stable version. I find that Horde_Stream_Filter 2.0.2 mostly fix the Bug #12673, but does not fix the case at "HTML message + Attachment + PGP signed". 1. Write a mail with HTML composition. 2. Add an attachment. I tried JPG/MP3 file. 3. Select encryption option to PGP sign message. 4. Send this message. 5. Verify this message, and "BAD signature" message appears. OS: Ubuntu server 12.04.3 64-bit (update all packages today) GnuPG: 1.4.11 PHP: 5.3.10-1ubuntu3.8 MySQL: 5.5.32-0ubuntu0.12.04.1

Add information: postfix: 2.9.6 dovecot: 2.0.19

Thu, 17 Oct 2013 09:40:11 +0000

Add information: postfix: 2.9.6 dovecot: 2.0.19

Cannot reproduce on master.

Thu, 17 Oct 2013 10:34:08 +0000

Cannot reproduce on master.

> Cannot reproduce on master. Please try the attached pic

Thu, 17 Oct 2013 11:20:42 +0000

> Cannot reproduce on master. Please try the attached picture as the attachment of PGP signed HTML message. This picture can reproduce the issue on the clean Horde webmail I installed on 10/17.

Add information: PGP certs I used are created from Horde

Fri, 18 Oct 2013 02:28:21 +0000

Add information: PGP certs I used are created from Horde Webmail Prefs -> Mail -> PGP UI.

Confirmed

Fri, 18 Oct 2013 11:15:05 +0000

Confirmed

I'm wondering if this fixes (i.e. upgrade to Horde_Smtp 1.2.

Sat, 19 Oct 2013 01:26:51 +0000

I'm wondering if this fixes (i.e. upgrade to Horde_Smtp 1.2.6): commit 72de48b9176a44df5cd06b441b64d22cfe425119 Author: Michael M Slusarz Date: Fri Oct 18 19:18:27 2013 -0600 [mms] Fix escaping periods that begin a line of DATA input. framework/Smtp/lib/Horde/Smtp/Filter/Data.php | 2 +- framework/Smtp/package.xml | 10 ++-- framework/Smtp/test/Horde/Smtp/FilterDataTest.php | 53 +++++++++++++++++++++ 3 files changed, 60 insertions(+), 5 deletions(-) create mode 100644 framework/Smtp/test/Horde/Smtp/FilterDataTest.php http://github.com/horde/horde/commit/72de48b9176a44df5cd06b441b64d22cfe425119 http://git.horde.org/horde-git/-/commit/72de48b9176a44df5cd06b441b64d22cfe425119

> I'm wondering if this fixes (i.e. upgrade to Horde_Smtp 1.

Mon, 21 Oct 2013 06:34:32 +0000

> I'm wondering if this fixes (i.e. upgrade to Horde_Smtp 1.2.6): > > commit 72de48b9176a44df5cd06b441b64d22cfe425119 > Author: Michael M Slusarz > Date: Fri Oct 18 19:18:27 2013 -0600 > > [mms] Fix escaping periods that begin a line of DATA input. > > framework/Smtp/lib/Horde/Smtp/Filter/Data.php | 2 +- > framework/Smtp/package.xml | 10 ++-- > framework/Smtp/test/Horde/Smtp/FilterDataTest.php | 53 > +++++++++++++++++++++ > 3 files changed, 60 insertions(+), 5 deletions(-) > create mode 100644 framework/Smtp/test/Horde/Smtp/FilterDataTest.php > > http://github.com/horde/horde/commit/72de48b9176a44df5cd06b441b64d22cfe425119 > http://git.horde.org/horde-git/-/commit/72de48b9176a44df5cd06b441b64d22cfe425119 This method does not fix the "BAD signature" issue in my platform.

There is some sort of fringe case going on here. I was able

Tue, 22 Oct 2013 03:20:32 +0000

There is some sort of fringe case going on here. I was able to reproduce last night from my laptop. But sending the EXACT same message from my desktop is not causing the issue. The issue has to do with extra spaces being inserted into the base64 output. The bad signature message has the following: VounL3tD6iFSE+oC5iyVcH2yOtYTvBGylG47MZPGPlPesEmpXZslBiEuQEA4Bp202IcU0Zmuq8cU k6TBSVJwy549/b2xXpZenzpo8nMYJ0j0D/gltOr6Brs7FVY61MAB93OeoFdvFNN+yT8l+R+S5nH/ Can verify that the bad signature is exactly two bytes larger - this additional CRLF in the middle of the data. However, I can't reproduce this anymore. So almost certain this is a transient issue dealing with stream EOL processing, that is only tripped on some sort of edge case I have yet to find.

Changes have been made in Git (master): commit 66c5fb351977

Tue, 22 Oct 2013 19:19:56 +0000

Changes have been made in Git (master): commit 66c5fb35197715df7957c4f461b33b18642d47d0 Author: Michael M Slusarz Date: Tue Oct 22 13:18:10 2013 -0600 [mms] Fix handling EOLs split on a stream bucket boundary (Bug #12763). framework/Smtp/lib/Horde/Smtp/Filter/Data.php | 5 +++++ framework/Smtp/package.xml | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/66c5fb35197715df7957c4f461b33b18642d47d0

Fixed in Horde_Smtp 1.2.7.

Tue, 22 Oct 2013 19:20:16 +0000

Fixed in Horde_Smtp 1.2.7.