History: Add getLatestEntry($guid)

Hi, I needed a way to get the latest history entry for a

Sat, 10 Aug 2013 15:42:00 +0000

Hi, I needed a way to get the latest history entry for a given $guid. Since I needed it in two places now, I thought it's a good idea to have a generic implementation in Horde_History. I've also written an efficient version for the SQL driver and tested both. Please see the attached patch. Cheers, Thomas

Looks like you attached the wrong patch?

Mon, 12 Aug 2013 18:23:43 +0000

Looks like you attached the wrong patch?

> Looks like you attached the wrong patch? thanks, this i

Mon, 12 Aug 2013 18:53:14 +0000

> Looks like you attached the wrong patch? thanks, this is the right one :)

You will need to add a GROUP BY clause if you are returning

Mon, 12 Aug 2013 19:28:56 +0000

You will need to add a GROUP BY clause if you are returning non-aggregate fields in the query along with an aggregate field (MAX). This will work in mySql, but not pgsql. That being said, can you just get rid of the MAX and use ORDER BY history_modseq DESC and add limit => 1 instead? See Bug: 12476 Also, would be great if you could add a test as well :)

> You will need to add a GROUP BY clause if you are returnin

Mon, 12 Aug 2013 20:31:43 +0000

> You will need to add a GROUP BY clause if you are returning > non-aggregate fields in the query along with an aggregate field > (MAX). This will work in mySql, but not pgsql. That being said, can > you just get rid of the MAX and use ORDER BY history_modseq DESC and > add limit => 1 instead? See Bug: 12476 ok, can do. > Also, would be great if you could add a test as well :) I knew you would say that :o) I'll revisit this probably after my holidays (=October). The latest changes to the Kolab Horde History already make use of it but as my pull request doesn't see any sign of live, it's not a problem anyway :P

> sign of live ...we all love this moment in life when yo

Mon, 12 Aug 2013 20:33:23 +0000

> sign of live ...we all love this moment in life when you spot a typo and already pressed the submit button :)

I've updated the code with the optimized SQL statement using

Wed, 21 Aug 2013 09:13:46 +0000

I've updated the code with the optimized SQL statement using ORDER BY. Also I've fixed a bug that only occurred during productive testing: If db->selectOne() didn't find a row, it returned an array with all the requested keys set and empty values. Could be related to the MAX() statement and/or the explicit specification of the field names in the previous SQL statement. Therefore I've adapted the code to check if $row['history_id'] is really set. No unit test yet, productive testing has to do for now :o)

Changes have been made in Git (master): commit e5df3a27d590

Thu, 22 Aug 2013 03:57:40 +0000

Changes have been made in Git (master): commit e5df3a27d590dfe98ec936cfc6706784593c5399 Author: Thomas Jarosch Date: Wed Aug 21 10:57:19 2013 +0200 Add getLatestEntry($guid) to get the latest history entry for a given $guid The SQL version is very efficient since it does not need to loop through all history entries for the object to determine the latest entry. Request 12558 Signed-off-by: Michael J Rubinsky framework/History/lib/Horde/History.php | 36 +++++++++++++++++++++++++++ framework/History/lib/Horde/History/Sql.php | 32 ++++++++++++++++++++++++ 2 files changed, 68 insertions(+), 0 deletions(-) http://git.horde.org/horde-git/-/commit/e5df3a27d590dfe98ec936cfc6706784593c5399

Committed, thanks!

Thu, 22 Aug 2013 03:58:04 +0000

Committed, thanks!