6.0.0-git
2019-05-19

[#12540] ErrorHandler: Only call $registry->isAdmin() if registry is available
Summary ErrorHandler: Only call $registry->isAdmin() if registry is available
Queue Horde Framework Packages
Queue Version Git master
Type Bug
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester thomas.jarosch (at) intra2net (dot) com
Created 2013-08-07 (2111 days ago)
Due
Updated 2013-08-07 (2111 days ago)
Assigned
Resolved 2013-08-07 (2111 days ago)
Milestone
Patch Yes

History
2013-08-07 23:18:49 Michael Slusarz Comment #3
Assigned to Michael Slusarz
State ⇒ Resolved
Reply to this comment
Horde_Core 2.6.6.
2013-08-07 23:18:09 Git Commit Comment #2 Reply to this comment
Changes have been made in Git (master):

commit 21bc7a682d0771fa0f55996664aaefdce0a467bb
Author: Michael M Slusarz <slusarz@horde.org>
Date:   Wed Aug 7 17:06:05 2013 -0600

     [mms] Ensure Registry exists in error handler before attempting 
to access it (Bug #12540).

  framework/Core/lib/Horde/ErrorHandler.php |    2 +-
  framework/Core/package.xml                |    4 ++--
  2 files changed, 3 insertions(+), 3 deletions(-)

http://git.horde.org/horde-git/-/commit/21bc7a682d0771fa0f55996664aaefdce0a467bb
2013-08-07 12:48:14 Thomas Jarosch Comment #1
Type ⇒ Bug
State ⇒ Unconfirmed
Priority ⇒ 1. Low
Summary ⇒ ErrorHandler: Only call $registry->isAdmin() if registry is available
Queue ⇒ Horde Framework Packages
Milestone ⇒
Patch ⇒ Yes
New Attachment: 0001-Only-call-registry-isAdmin-if-registry-is-already-av.patch Download
Reply to this comment
Hi,

attached patch fixes the ErrorHandler if the registry is not yet available.

Without the patch, the ErrorHandler crashed like this:
[Wed Aug 07 14:38:42 2013] [error] [client 127.0.0.1] PHP Fatal error: 
  Call to a member function isAdmin() on a non-object in 
/datastore/share/pear/Horde/ErrorHandler.php on line 81

Cheers,
Thomas

Saved Queries