Fri, 10 Apr 2026 11:02:36 +0000 https://bugs.horde.org/ticket/124 bug in javascript call when filtering based on keyword When trying to call an ad with a javascript call to.. http://i-pt.securesites.com/midas/ad.php?d=js&k=KEYWORD returns errors: Notice: Undefined variable: keyword in /usr/local/etc/httpd/vhosts/horde-cvs/midas/lib/Campaigns.php on line 115 Fatal error: Call to a member function on a non-object in /usr/local/etc/httpd/vhosts/horde-cvs/midas/lib/Campaigns.php on line 118 Error 1 is fixed by changing /* Split up all the keywords into an array consisting only of * unique keywords. */ - $target_words = array_unique(preg_split('|\s+|', $keyword)); + $target_words = array_unique(preg_split('|\s+|', $target_words)); } $avail_words = $this->_campaigns->getKeywords('active'); Error 2 I have tried to follow the code and cannot find anything. So was hoping if someone else could cast an eye on this. Thanks, tim. Mon, 26 Apr 2004 19:34:28 +0000 https://bugs.horde.org/ticket/124#t479 Mon, 26 Apr 2004 19:37:15 +0000 https://bugs.horde.org/ticket/124#t480 Fixed in CVS. Mon, 26 Apr 2004 22:23:26 +0000 https://bugs.horde.org/ticket/124#t481 Now some random behaviour ie. calling http://site.com/midas/ad.php?d=js the output may be document.write(''); **note empty quotes or document.write('[IMAGE]'); ** ie correct or Notice: Undefined offset: 3 in /usr/local/etc/httpd/vhosts/horde-cvs/midas/lib/Campaigns.php on line 102 document.write('[IMAGE]'); setting a k=KEYWORD does not actually restrict selection to the ones with a (the) KEYWORD set, but seems show any ad available. Tue, 27 Apr 2004 11:51:09 +0000 https://bugs.horde.org/ticket/124#t482 Ok, reopening this. Wed, 28 Apr 2004 13:38:13 +0000 https://bugs.horde.org/ticket/124#t483 Fixed the type and keyword filtering, as well as a bunch of other small typos, errors and miscalculations, which all put together meant erratic results. Sun, 02 May 2004 22:47:35 +0000 https://bugs.horde.org/ticket/124#t484