Caldav for -system- shares

Hi, I'm currently at B1 hack week. I noticed the caldav inte

Wed, 12 Jun 2013 08:57:39 +0000

Hi, I'm currently at B1 hack week. I noticed the caldav interface does not support -system- shares. Is there any technical intricacy preventing this? Otherwise I'd go for a simple patch tonight.

Bug #12325

Wed, 12 Jun 2013 21:36:28 +0000

Bug #12325

Not exactly. There's more to Caldav not knowing -system-.

Fri, 05 Jul 2013 14:14:33 +0000

Not exactly. There's more to Caldav not knowing -system-. I've been looking around for where to patch in -system- support for Dav shares. (kronolith, nag, turba). The Horde_Dav system expects -system- to be a user existing in Horde_Auth and having an Identity. I'm not sure if I should provide a static fake identity and always have a user -system- in the dav library or if I should promote -system- to a first class special user. I'm more leaning to the former (less invasive). All the converting between shares owned by "" (system) and the -system- tag seems already to be handled by kronolith/nag themselves in browse() and friends.

On 06.07.2013 07:05, Ralf Lang wrote:> On 05.07.2013 17:32,

Thu, 11 Jul 2013 11:29:08 +0000

On 06.07.2013 07:05, Ralf Lang wrote:> On 05.07.2013 17:32, Jan Schneider wrote: >> >> Zitat von Ralf Lang : >> >>> If've been looking around for where to patch in -system- support for Dav >>> shares. (kronolith, nag, turban). >>> >>> The Horde_Dav system expects -system- to be a user existing in >>> Horde_Auth and having an Identity. I'm not sure if I should provide a >>> static fake identity and always have a user -system- in the dav library >>> or if I should promote -system- to a first class special user. I'm more >>> leaning to the former (less invasive). >> >> Can you point to the code where this is required? Generally the former >> sounds indeed like a better solution. > > I did a quick draft yesterday > > 1) Horde_Dav_Principals::getPrincipalsByPrefix > - $users = array('-system-') > + $users = array('-system-') > > 2) Horde_Dav_Principals::getPrincipalsByPath > -- if ($this->_auth->hasCapability('list') && > -- !$this->_auth->exists($user)) { > ++ if ($this->_auth->hasCapability('list') && > ++ !$this->_auth->exists($user) && > ++ $user != '-system-') { > > > 3) Horde_Dav_Principals::_getUserInfo > { > ++ if ($user == '-system-') { > ++ return array( > ++ 'uri' => 'principals/-system-', > ++ '{DAV:}displayname' => '-systems-', > ++ '{http://sabredav.org/ns}email-address' => '' > ++ /* Can we leave email empty, set something static or > ++ pull something from a fake identity? */ > ++ } > $identitiy = $this->_identities->create(user); > > This was enough for making system appear and list credentials under it > (together with the kronolith patch from > http://bugs.horde.org/ticket/12325 which was for WebDAV -- may need to > amend callDavFoo too to make it actually crud events from calendars ) 4) Horde_Dav_Principals Give access to the calendars/-system- and principals/-system- level to all users. This probably needs more configuration. public function getGroupMembership($principal) { // All users should have access to the -system- share. // Needs reimplementation when horde finally implements group acls as share groups return array('principals/-system-'); } 5) patch Kronolith_Application::davGetCollections to user '' in query but '-system-' in building structures. We probably need this in nag to public function davGetCollections($user) { ++ $queryUser = $user == '-system-' ? '' : $user; ... ->listShares( $GLOBALS['registry']->getAuth(), array('perm' => Horde_Perms::SHOW, -- 'attributes' => $user) ++ 'attributes' => $queryUser) ); 6) Same show for nag public function davGetCollections($user) { ++ $queryUser = $user == '-system-' ? '' : $user; $shares = $GLOBALS['nag_shares'] ->listShares( $GLOBALS['registry']->getAuth(), array('perm' => Horde_Perms::SHOW, -- 'attributes' => $user) ++ 'attributes' => $queryUser) ); TODO: either implement filters for listSystemShares or add a systemShares filter option for listShares. listShares with permission::SHOW and empty user may return unrelated non-system 3rd party shares the user has SHOW access for. Next: push a patch to master.

> TODO: either implement filters for listSystemShares or a

Thu, 11 Jul 2013 11:37:25 +0000

> TODO: either implement filters for listSystemShares or add a > systemShares filter option for listShares. listShares with > permission::SHOW and empty user may return unrelated non-system 3rd > party shares the user has SHOW access for. Workaround: after fetching the listShares, filter if share has an owner: foreach ($shares as $id => $share) { ++ if (empty($queryUser) && $share->get('owner')) { ++ continue; ++ } > > Next: push a patch to master.

Changes have been made in Git (master): commit 1e332785107f

Thu, 11 Jul 2013 12:05:31 +0000

Changes have been made in Git (master): commit 1e332785107f7373a987145eafdae8cb3fa30a51 Author: Ralf Lang Date: Thu Jul 11 15:03:30 2013 +0300 Add CalDAV Support for system shares in nag and kronolith for Request #12342. This does not address CardDAV and Turba yet, but it is probably very similar. Note I have not a very deep understanding of CardDAV or CalDAV protocol. framework/Dav/lib/Horde/Dav/Principals.php | 19 ++++++++++++++++--- framework/Dav/package.xml | 2 ++ kronolith/docs/CHANGES | 1 + kronolith/lib/Application.php | 6 +++++- kronolith/package.xml | 2 ++ nag/docs/CHANGES | 1 + nag/lib/Application.php | 6 +++++- nag/package.xml | 2 ++ 8 files changed, 34 insertions(+), 5 deletions(-) http://git.horde.org/horde-git/-/commit/1e332785107f7373a987145eafdae8cb3fa30a51

Changes have been made in Git (master): commit 6c47f32326f8

Tue, 16 Jul 2013 13:46:29 +0000

Changes have been made in Git (master): commit 6c47f32326f85c4ce1b9339862015b5f29fd7e0b Author: Jan Schneider Date: Tue Jul 16 14:56:35 2013 +0200 [jan] Display CalDAV URL of system calendars and tasklists (Bug #12342). kronolith/docs/CHANGES | 1 + kronolith/js/kronolith.js | 4 +- kronolith/lib/Calendar/External/Tasks.php | 10 +++----- kronolith/lib/Calendar/Internal.php | 10 +++----- kronolith/lib/Form/EditCalendar.php | 30 ++++++++++++++-------------- kronolith/package.xml | 2 + kronolith/templates/chunks/calendar.php | 4 +- 7 files changed, 30 insertions(+), 31 deletions(-) http://git.horde.org/horde-git/-/commit/6c47f32326f85c4ce1b9339862015b5f29fd7e0b

Changes have been made in Git (master): commit 6d75378fdaa2

Tue, 16 Jul 2013 13:46:33 +0000

Changes have been made in Git (master): commit 6d75378fdaa271b8952e9819f42415cbac9e5f4c Author: Jan Schneider Date: Tue Jul 16 15:16:26 2013 +0200 [jan] Display CalDAV URL of system tasklists (Bug #12342). nag/docs/CHANGES | 1 + nag/lib/Form/EditTaskList.php | 30 +++++++++++++++--------------- nag/package.xml | 2 ++ 3 files changed, 18 insertions(+), 15 deletions(-) http://git.horde.org/horde-git/-/commit/6d75378fdaa271b8952e9819f42415cbac9e5f4c