Invalid s/mime cert leads to crash

Hi, when you create a new contact and enter garbage in th

Wed, 17 Oct 2012 08:03:26 +0000

Hi, when you create a new contact and enter garbage in the s/mime field, turba gives you (partly) the blank page of death. Logged error: 2012-10-17T10:00:44+02:00 EMERG: HORDE [turba] DateTime::__construct() [datetime.--construct]: Failed to parse time string (@) at position 0 (@): Unexpected character [pid 15656 on line 557 of "/datastore/DEVEL/horde/framework/Crypt/lib/Horde/Crypt/Smime.php"] Cheers, Thomas

Changes have been made in Git (master): commit 0c9032084dcd

Wed, 17 Oct 2012 12:41:30 +0000

Changes have been made in Git (master): commit 0c9032084dcd1a9e0490a9a6af3557376541a326 Author: Jan Schneider Date: Wed Oct 17 14:40:39 2012 +0200 [jan] Throw exception if parsing of S/MIME certificates fails (Bug #11530). framework/Crypt/lib/Horde/Crypt/Smime.php | 3 +++ framework/Crypt/package.xml | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/0c9032084dcd1a9e0490a9a6af3557376541a326

Changes have been made in Git (master): commit 3bb600de48ef

Wed, 17 Oct 2012 12:41:36 +0000

Changes have been made in Git (master): commit 3bb600de48ef23292e59e8bf33455c83f8e442eb Author: Jan Schneider Date: Wed Oct 17 14:41:12 2012 +0200 [jan] Catch exceptions from Horde_Crypt (Bug #11530). .../Core/lib/Horde/Core/Ui/VarRenderer/Html.php | 9 ++++++++- framework/Core/package.xml | 2 ++ 2 files changed, 10 insertions(+), 1 deletions(-) http://git.horde.org/horde-git/-/commit/3bb600de48ef23292e59e8bf33455c83f8e442eb

Any reason this can't/shouldn't be backported to FRAMEWORK_4

Mon, 22 Oct 2012 19:26:24 +0000

Any reason this can't/shouldn't be backported to FRAMEWORK_4?

Changes have been made in Git (FRAMEWORK_4): commit 2aaf8a9

Tue, 23 Oct 2012 16:09:12 +0000

Changes have been made in Git (FRAMEWORK_4): commit 2aaf8a963b262663115fe04969a0ca6a17025b6f Author: Jan Schneider Date: Wed Oct 17 14:40:39 2012 +0200 [jan] Throw exception if parsing of S/MIME certificates fails (Bug #11530). Conflicts: framework/Crypt/package.xml framework/Crypt/lib/Horde/Crypt/Smime.php | 3 +++ framework/Crypt/package.xml | 2 ++ 2 files changed, 5 insertions(+), 0 deletions(-) http://git.horde.org/horde-git/-/commit/2aaf8a963b262663115fe04969a0ca6a17025b6f

Changes have been made in Git (FRAMEWORK_4): commit a4de0d9

Tue, 23 Oct 2012 16:09:17 +0000

Changes have been made in Git (FRAMEWORK_4): commit a4de0d9e61b75d416ce0992e9235dcad2413e26e Author: Jan Schneider Date: Wed Oct 17 14:41:12 2012 +0200 [jan] Catch exceptions from Horde_Crypt (Bug #11530). Conflicts: framework/Core/package.xml .../Core/lib/Horde/Core/Ui/VarRenderer/Html.php | 9 ++++++++- framework/Core/package.xml | 2 ++ 2 files changed, 10 insertions(+), 1 deletions(-) http://git.horde.org/horde-git/-/commit/a4de0d9e61b75d416ce0992e9235dcad2413e26e

It's technical a BC break because we throw an exception wher

Tue, 23 Oct 2012 16:10:06 +0000

It's technical a BC break because we throw an exception where we didn't before, but this is not different from letting DateTime throw an exception that we don't catch, so I merged it.

Thanks.

Tue, 23 Oct 2012 19:55:16 +0000

Thanks.

Changes have been made in Git (develop): commit 0c9032084dc

Sat, 27 Oct 2012 00:56:20 +0000

Changes have been made in Git (develop): commit 0c9032084dcd1a9e0490a9a6af3557376541a326 Author: Jan Schneider Date: Wed Oct 17 14:40:39 2012 +0200 [jan] Throw exception if parsing of S/MIME certificates fails (Bug #11530). framework/Crypt/lib/Horde/Crypt/Smime.php | 3 +++ framework/Crypt/package.xml | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/0c9032084dcd1a9e0490a9a6af3557376541a326

Changes have been made in Git (develop): commit 3bb600de48e

Sat, 27 Oct 2012 00:56:24 +0000

Changes have been made in Git (develop): commit 3bb600de48ef23292e59e8bf33455c83f8e442eb Author: Jan Schneider Date: Wed Oct 17 14:41:12 2012 +0200 [jan] Catch exceptions from Horde_Crypt (Bug #11530). .../Core/lib/Horde/Core/Ui/VarRenderer/Html.php | 9 ++++++++- framework/Core/package.xml | 2 ++ 2 files changed, 10 insertions(+), 1 deletions(-) http://git.horde.org/horde-git/-/commit/3bb600de48ef23292e59e8bf33455c83f8e442eb