Identity selection doesn't work

Automatic identity selection on replies/forwards doesn't wor

Mon, 02 Jul 2012 17:25:21 +0000

Automatic identity selection on replies/forwards doesn't work anymore.

Works fine here. Just replied to a list message, and my ide

Thu, 05 Jul 2012 19:07:03 +0000

Works fine here. Just replied to a list message, and my identity was correctly set to my (non-default) Horde identity.

Should the identity parameter still be passed to the compose

Thu, 05 Jul 2012 19:30:11 +0000

Should the identity parameter still be passed to the compose window? I don't see it in its URL. Or this completely matched in compose-dimp.php now?

> Should the identity parameter still be passed to the compo

Thu, 05 Jul 2012 20:04:30 +0000

> Should the identity parameter still be passed to the compose window? > I don't see it in its URL. Or this completely matched in > compose-dimp.php now? The identity parameter CAN be passed - but it will be overridden by the identity determination when determining reply/forward data (in other words: preferences trump any identity parameter passed in URL/form data).

>> Should the identity parameter still be passed to the comp

Thu, 05 Jul 2012 20:26:16 +0000

>> Should the identity parameter still be passed to the compose window? >> I don't see it in its URL. Or this completely matched in >> compose-dimp.php now? > > The identity parameter CAN be passed - but it will be overridden by > the identity determination when determining reply/forward data (in > other words: preferences trump any identity parameter passed in > URL/form data). Where is this happening, so I can easier track it down?

> Where is this happening, so I can easier track it down?

Thu, 05 Jul 2012 21:15:14 +0000

> Where is this happening, so I can easier track it down? The parsing of the URL parameter? IMP_Dynamic_Compose, around line 60.

>> Where is this happening, so I can easier track it down?

Thu, 05 Jul 2012 21:24:56 +0000

>> Where is this happening, so I can easier track it down? > > The parsing of the URL parameter? IMP_Dynamic_Compose, around line 60. No, the identity selection if *not* using the parameter.

>>> Where is this happening, so I can easier track it down?

Thu, 05 Jul 2012 21:43:20 +0000

>>> Where is this happening, so I can easier track it down? >> >> The parsing of the URL parameter? IMP_Dynamic_Compose, around line 60. > > No, the identity selection if *not* using the parameter. The 'identity' key in the return array of IMP_Compose#replyMessage() and IMP_Compose#forwardMessage().

>>>> Where is this happening, so I can easier track it down?

Thu, 05 Jul 2012 22:08:00 +0000

>>>> Where is this happening, so I can easier track it down? >>> >>> The parsing of the URL parameter? IMP_Dynamic_Compose, around line 60. >> >> No, the identity selection if *not* using the parameter. > > The 'identity' key in the return array of IMP_Compose#replyMessage() > and IMP_Compose#forwardMessage(). This is what happens: in Imp_Prefs_Identity#getMatchingIdentity() all message addresses (From:, To:) are passed to contains(). Horde_Mail_Rfc822_List#contains() wraps this list into Horde_Mail_Rfc822_Address() which only contains the first address (From:) after that. Of course the match() below doesn't work anymore then. I have no idea how this is working on your system.

Changes have been made in Git (develop): commit 193ef607b07

Thu, 05 Jul 2012 22:23:31 +0000

Changes have been made in Git (develop): commit 193ef607b07f4e2e64b5b18f569700c861b6ef98 Author: Michael M Slusarz Date: Thu Jul 5 16:23:00 2012 -0600 Bug #11234: Fix identity selection when replying/forwarding to a message sent from a personal from address. imp/lib/Prefs/Identity.php | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) http://git.horde.org/horde-git/-/commit/193ef607b07f4e2e64b5b18f569700c861b6ef98

> I have no idea how this is working on your system. This

Thu, 05 Jul 2012 22:27:29 +0000

> I have no idea how this is working on your system. This was working for me because I was matching "tie-to" addresses. As you discovered, the search/match was failing at the "from" search, which is an extremely rare fringe case. This match would only be triggered if replying to one of your own messages Since replies to list are triggered at the tie-to level (lists will never be a From address), this was the reason I wasn't seeing this.

>> I have no idea how this is working on your system. > >

Thu, 05 Jul 2012 22:35:09 +0000

>> I have no idea how this is working on your system. > > This was working for me because I was matching "tie-to" addresses. > As you discovered, the search/match was failing at the "from" search, > which is an extremely rare fringe case. This match would only be > triggered if replying to one of your own messages > > Since replies to list are triggered at the tie-to level (lists will > never be a From address), this was the reason I wasn't seeing this. Not quite, this happened in almost all cases, because if my identities would match the From: address, it wouldn't matter if only that address was compared. But since the To: address was dropped, in never worked, unless I had tied-to addresses set (didn't test the latter). Anyway, works fine now, thanks!

Changes have been made in Git (master): commit 193ef607b07f

Wed, 29 Aug 2012 12:40:28 +0000

Changes have been made in Git (master): commit 193ef607b07f4e2e64b5b18f569700c861b6ef98 Author: Michael M Slusarz Date: Thu Jul 5 16:23:00 2012 -0600 Bug #11234: Fix identity selection when replying/forwarding to a message sent from a personal from address. imp/lib/Prefs/Identity.php | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) http://git.horde.org/horde-git/-/commit/193ef607b07f4e2e64b5b18f569700c861b6ef98