Favourites driver matches all email address searches

I have Imp 5.0.21 (just upgraded a couple of days ago, inclu

Fri, 01 Jun 2012 11:21:43 +0000

I have Imp 5.0.21 (just upgraded a couple of days ago, including clearing cache etc). No other changes on the server in recent weeks. In my Imp preferences, the following is set: Block images in messages unless they are specifically requested? - YES Automatically show images in messages when the sender is in my address book? - YES Imp no longer asks if I want to show blocked images (both Traditional and Dynamic), but shows all HTML images for ALL emails, regardless of whether the sender is in my address book. I have tried from a PC and my iPad - both the same. Did something change?

Beside that, it looks like address book lookups haven't been

Mon, 04 Jun 2012 12:21:13 +0000

Beside that, it looks like address book lookups haven't been used for 20 months without anyone noticing. Unless I'm missing something. AFAIC address book lookups have been (accidentally) removed in commit 91ffa129ee86b75d506351e1d6ac66e921676273.

> Beside that, it looks like address book lookups haven't be

Mon, 04 Jun 2012 20:21:09 +0000

> Beside that, it looks like address book lookups haven't been used for > 20 months without anyone noticing. Unless I'm missing something. > AFAIC address book lookups have been (accidentally) removed in commit > 91ffa129ee86b75d506351e1d6ac66e921676273. Addressbook lookups occur in IMP_Ui_Imageview::showInlineImage(). _inAddressBook() is dead code, but that has been known for awhile. I have never seen a need to remove it in IMP 5 though (it was long ago removed in IMP 6).

> Did something change? No.

Mon, 04 Jun 2012 20:22:29 +0000

> Did something change? No.

>> Did something change? > > No. With respect to 5.0.20

Mon, 04 Jun 2012 20:30:23 +0000

>> Did something change? > > No. With respect to 5.0.20 -> 5.0.21.

>>> Did something change? >> >> No. > > With respect to

Mon, 04 Jun 2012 22:23:21 +0000

>>> Did something change? >> >> No. > > With respect to 5.0.20 -> 5.0.21. I don't usually believe in coincidences... Ever since running Horde I have had images blocked in HTML emails, with the exception of a couple of regular HTML newsletters that I get, which I have added to the Address Book so that I don't have to click on Show Blocked Iimages for these emails that I trust. I.e. this is not something new that I am playing with... I upgraded to 5.0.21, and the next day I noticed that images are not being blocked any more. Nothing else was changed on that server at that time. What would be great would be some help on working out why it is doing it now all of a sudden, apparently coincidentally :-/

I tried unsetting the pref, saving it, and logging out. Logg

Mon, 04 Jun 2012 22:44:01 +0000

I tried unsetting the pref, saving it, and logging out. Logged back in, and the preference was correctly still set as not ticked. As expected at that point, all images download without prompting for blocked images. I then ticked the preference to block emails, logged out, and logged back in, and the preference again had correctly been retained. However, actual behaviour in Imp remains incorrect - all images are still downloaded. The preference appears to be correctly maintained, but Imp is ignoring it.

There is nothing wrong with the preferences. And I have ver

Mon, 04 Jun 2012 23:08:38 +0000

There is nothing wrong with the preferences. And I have verified multiple times that nothing has changed in IMP 5 relating to the image viewing code. On my system, however, something appears broken with the Turba getField API call. It matches ALL entries in the favourites table, even if those emails do not match the search query (the matches are not even close). The query being run is this: Array ( [AND] => Array ( [0] => Array ( [field] => email [op] => = [test] => foo@example.com ) ) ) Two problems with this query: 1) The code in the Favourites driver does not handle the '=' op, only the LIKE op. 2) Any AND query that doesn't match will be considered as "found" and will be returned. (That's why the absence of the '=' op constititues matching). Thus any email address, if querying the favourites addressbook, will ALWAYS be considered matched AFAICT. No idea if this is your issue and, if so, why it suddenly started when upgrading only IMP.

We no longer use contacts/getField API call in IMP 6, so thi

Mon, 04 Jun 2012 23:10:01 +0000

We no longer use contacts/getField API call in IMP 6, so this is not an issue there (we use contacts/search).

> There is nothing wrong with the preferences. And I have v

Tue, 05 Jun 2012 01:15:56 +0000

> There is nothing wrong with the preferences. And I have verified > multiple times that nothing has changed in IMP 5 relating to the > image viewing code. > > On my system, however, something appears broken with the Turba > getField API call. It matches ALL entries in the favourites table, > even if those emails do not match the search query (the matches are > not even close). The query being run is this: > > Array > ( > [AND] => Array > ( > [0] => Array > ( > [field] => email > [op] => = > [test] => foo@example.com > ) > ) > ) > > Two problems with this query: > 1) The code in the Favourites driver does not handle the '=' op, only > the LIKE op. > 2) Any AND query that doesn't match will be considered as "found" and > will be returned. (That's why the absence of the '=' op constititues > matching). > > Thus any email address, if querying the favourites addressbook, will > ALWAYS be considered matched AFAICT. No idea if this is your issue > and, if so, why it suddenly started when upgrading only IMP. Aha, progress... Unselect "Automatically show images in messages when the sender is in my address book?" and it works again. So you are spot-on, it is matching everything as being in the address book.

Changes have been made in Git (master): commit db87df86571a

Tue, 05 Jun 2012 09:07:18 +0000

Changes have been made in Git (master): commit db87df86571a87ed8c0ef19826e13caae939935a Author: Jan Schneider Date: Tue Jun 5 11:06:27 2012 +0200 Correctly build AND queries, implement strict searching (Bug #11207). turba/docs/CHANGES | 1 + turba/lib/Driver/Favourites.php | 57 ++++++++++++++++++++++++++------------ turba/package.xml | 4 +- 3 files changed, 42 insertions(+), 20 deletions(-) http://git.horde.org/horde-git/-/commit/db87df86571a87ed8c0ef19826e13caae939935a

Wow... Impressively quick fix. Thanks, will chuck that in

Tue, 05 Jun 2012 10:17:19 +0000

Wow... Impressively quick fix. Thanks, will chuck that in and confirm.

Changes have been made in Git (develop): commit db87df86571

Tue, 05 Jun 2012 19:49:53 +0000

Changes have been made in Git (develop): commit db87df86571a87ed8c0ef19826e13caae939935a Author: Jan Schneider Date: Tue Jun 5 11:06:27 2012 +0200 Correctly build AND queries, implement strict searching (Bug #11207). turba/docs/CHANGES | 1 + turba/lib/Driver/Favourites.php | 57 ++++++++++++++++++++++++++------------ turba/package.xml | 4 +- 3 files changed, 42 insertions(+), 20 deletions(-) http://git.horde.org/horde-git/-/commit/db87df86571a87ed8c0ef19826e13caae939935a

FWIW, this would have first been seen as broken in IMP 5.0.2

Wed, 06 Jun 2012 20:52:05 +0000

FWIW, this would have first been seen as broken in IMP 5.0.20, not 5.0.21, since we switched to exact address searching after 5.0.19. So upgrading from 5.0.20->5.0.21 would not have changed anything: commit 1e26935a7c16a327f1c60e43bf00a100ab48bfda Author: Michael M Slusarz Date: Tue Mar 6 12:56:06 2012 -0700 This should be an exact address search ----- slusarz@bigworm % git show imp-5.0.20 tag imp-5.0.20 Tagger: Jan Schneider Date: Wed Apr 11 12:36:58 2012 +0200 Released imp-5.0.20.

Noted... looking in my upgrade records, my last Imp u/g was

Fri, 08 Jun 2012 03:27:21 +0000

Noted... looking in my upgrade records, my last Imp u/g was to 5.0.19, i.e. I skipped .20, which I should have checked and made clear in my original post. > FWIW, this would have first been seen as broken in IMP 5.0.20, not > 5.0.21, since we switched to exact address searching after 5.0.19. > So upgrading from 5.0.20->5.0.21 would not have changed anything: > > commit 1e26935a7c16a327f1c60e43bf00a100ab48bfda > Author: Michael M Slusarz > Date: Tue Mar 6 12:56:06 2012 -0700 > > This should be an exact address search > > ----- > > slusarz@bigworm % git show imp-5.0.20 > tag imp-5.0.20 > Tagger: Jan Schneider > Date: Wed Apr 11 12:36:58 2012 +0200 > > Released imp-5.0.20.