Re-add show-images-by-address-book

Not having to store senders in the address book whose messag

Tue, 20 Mar 2012 08:26:54 +0000

Not having to store senders in the address book whose messages should have their embedded images displayed is a great feature that I really missed in the past. This should not *replace* the whitelist by address book recipients though. I'd like to have this back, additionally, and I'm sure users will complain after they upgraded to H5 too.

Oh, and while I'm there, though this not exactly the same is

Tue, 20 Mar 2012 08:28:43 +0000

Oh, and while I'm there, though this not exactly the same issue, it would be great to automatically load the images of the current message after whitelisting a sender. This used to work when adding sender to the address book too.

> This should not replace the whitelist by address book re

Sat, 24 Mar 2012 14:35:25 +0000

> This should not *replace* the whitelist by address book recipients > though. I'd like to have this back, additionally, and I'm sure users > will complain after they upgraded to H5 too. I haven't removed this code. The new image_replacement_addrs preference is in addition to the addressbook whitelist check. See IMP_Ui_Imageview#showInlineImage().

> Oh, and while I'm there, though this not exactly the same

Sat, 24 Mar 2012 14:45:23 +0000

> Oh, and while I'm there, though this not exactly the same issue, it > would be great to automatically load the images of the current > message after whitelisting a sender. I thought it did? Although... it probably doesn't since imageunblock.js does the bare minimum and delegates other features to the base page script via the unblock event. > This used to work when adding > sender to the address book too. This definitely isn't true for dynamic view. The addContact AJAX call does not define a callback. This doesn't seem like expected behavior to a user either. And it's really not that big of a deal warranting a potentially complicated mechanism to do this for a single message - I can't imaging a user complaining that they had to manually display images in this situation.

Changes have been made in Git (develop): commit 1390bd940cd

Sat, 24 Mar 2012 14:52:58 +0000

Changes have been made in Git (develop): commit 1390bd940cd0ff631bd2a42af941bf0cff9abec7 Author: Michael M Slusarz Date: Sat Mar 24 08:51:06 2012 -0600 Bug #11091: Unblock images when adding to whitelist imp/js/dimpcore.js | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) http://git.horde.org/horde-git/-/commit/1390bd940cd0ff631bd2a42af941bf0cff9abec7

Closing since the original issue doesn't exist (it wasn't re

Tue, 27 Mar 2012 22:04:38 +0000

Closing since the original issue doesn't exist (it wasn't removed) and the remaining issues have been fixed.

>> This used to work when adding >> sender to the address b

Wed, 28 Mar 2012 09:48:09 +0000

>> This used to work when adding >> sender to the address book too. > > This definitely isn't true for dynamic view. The addContact AJAX > call does not define a callback. Yeah, maybe I confused this with the traditional view.

Changes have been made in Git (master): commit 1390bd940cd0

Wed, 29 Aug 2012 12:33:51 +0000

Changes have been made in Git (master): commit 1390bd940cd0ff631bd2a42af941bf0cff9abec7 Author: Michael M Slusarz Date: Sat Mar 24 08:51:06 2012 -0600 Bug #11091: Unblock images when adding to whitelist imp/js/dimpcore.js | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) http://git.horde.org/horde-git/-/commit/1390bd940cd0ff631bd2a42af941bf0cff9abec7