avoiding lots of empty ldap connections

Hello, The construct method of the ldap driver is doing a

Sat, 17 Mar 2012 11:52:51 +0000

Hello, The construct method of the ldap driver is doing a connect/bind. Most of the time there is no search and there is an unbind after. I propose to add an init method which is called if _ds==null in order to use just connects when searching or writing information. Dom

Looks good, but please update your patch to: - follow codin

Mon, 19 Mar 2012 21:46:35 +0000

Looks good, but please update your patch to: - follow coding standards (indention, whitespace, curly braces) - make the method protected and call it _connect() - check if $this->_ds is set *inside* _connect()

> Looks good, but please update your patch to: > - follow c

Tue, 20 Mar 2012 07:55:22 +0000

> Looks good, but please update your patch to: > - follow coding standards (indention, whitespace, curly braces) > - make the method protected and call it _connect() > - check if $this->_ds is set *inside* _connect() Sure, it make sense OK, I'm not a specialist of PHP, PERL is my language, so I apologize for my poor PHP coding. So my second patch is following

Almost there. :) - Your patch removes a line that doesn't e

Tue, 20 Mar 2012 08:06:40 +0000

Almost there. :) - Your patch removes a line that doesn't exist in the original file, please make sure to make the patch against the last release or Git version - The $this->_ds==null check should be *inside* _connect() to avoid redundency, and you need spaces before and after the operator

OK. I have no idea to get the very last version of Ldap.php

Tue, 20 Mar 2012 10:49:46 +0000

OK. I have no idea to get the very last version of Ldap.php throught git. Can I do that with an http access? I should have work directly on Ldap.php at first and may be modified the original.. > Almost there. :) > - Your patch removes a line that doesn't exist in the original file, > please make sure to make the patch against the last release or Git > version > - The $this->_ds==null check should be *inside* _connect() to avoid > redundency, and you need spaces before and after the operator OK

> OK. I have no idea to get the very last version of Ldap.ph

Tue, 20 Mar 2012 10:56:13 +0000

> OK. I have no idea to get the very last version of Ldap.php throught > git. Can I do that with an http access? https://raw.github.com/horde/horde/master/turba/lib/Driver/Ldap.php > I should have work directly on Ldap.php at first and may be modified > the original.. > > >> Almost there. :) >> - Your patch removes a line that doesn't exist in the original file, >> please make sure to make the patch against the last release or Git >> version >> - The $this->_ds==null check should be *inside* _connect() to avoid >> redundency, and you need spaces before and after the operator > > OK >

>> OK. I have no idea to get the very last version of Ldap.p

Wed, 21 Mar 2012 10:32:49 +0000

>> OK. I have no idea to get the very last version of Ldap.php throught >> git. Can I do that with an http access? > > https://raw.github.com/horde/horde/master/turba/lib/Driver/Ldap.php > >> I should have work directly on Ldap.php at first and may be modified >> the original.. >> >> >>> Almost there. :) >>> - Your patch removes a line that doesn't exist in the original file, >>> please make sure to make the patch against the last release or Git >>> version >>> - The $this->_ds==null check should be *inside* _connect() to avoid >>> redundency, and you need spaces before and after the operator >> >> OK >> > Hope this is OK now!

Changes have been made in Git (master): commit 1b1672cfb7ed

Wed, 21 Mar 2012 15:44:41 +0000

Changes have been made in Git (master): commit 1b1672cfb7ed2a380c2256f15a10e940b66662e4 Author: Jan Schneider Date: Wed Mar 21 16:44:27 2012 +0100 [jan] Only connect to LDAP driver for read/write requests (Dominique Lalot , Request #11082). turba/docs/CHANGES | 2 ++ turba/lib/Driver/Ldap.php | 26 +++++++++++++++++++++++++- turba/package.xml | 2 ++ 3 files changed, 29 insertions(+), 1 deletions(-) http://git.horde.org/horde-git/-/commit/1b1672cfb7ed2a380c2256f15a10e940b66662e4

Perfect, thanks for your patience!

Wed, 21 Mar 2012 15:45:26 +0000

Perfect, thanks for your patience!

Changes have been made in Git (develop): commit 1b1672cfb7e

Wed, 21 Mar 2012 19:19:59 +0000

Changes have been made in Git (develop): commit 1b1672cfb7ed2a380c2256f15a10e940b66662e4 Author: Jan Schneider Date: Wed Mar 21 16:44:27 2012 +0100 [jan] Only connect to LDAP driver for read/write requests (Dominique Lalot , Request #11082). turba/docs/CHANGES | 2 ++ turba/lib/Driver/Ldap.php | 26 +++++++++++++++++++++++++- turba/package.xml | 2 ++ 3 files changed, 29 insertions(+), 1 deletions(-) http://git.horde.org/horde-git/-/commit/1b1672cfb7ed2a380c2256f15a10e940b66662e4