Listshares cache is not beeing used when previous result is an empty array

The listshares stores an empty array on cache, but when it v

Thu, 01 Mar 2012 19:30:25 +0000

The listshares stores an empty array on cache, but when it verifies the existence of cache, it check if the value is !empty

Changes have been made in Git (develop): commit fc4877ab48a

Thu, 08 Mar 2012 05:18:56 +0000

Changes have been made in Git (develop): commit fc4877ab48a28d5375f7a42af4989e179c24f58c Author: Michael J Rubinsky Date: Thu Mar 8 00:18:02 2012 -0500 [mjr] Properly cache empty listShares results (Bug #11045). framework/Share/lib/Horde/Share/Sql.php | 6 +++--- framework/Share/lib/Horde/Share/Sqlng.php | 6 +++--- framework/Share/package.xml | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) http://git.horde.org/horde-git/-/commit/fc4877ab48a28d5375f7a42af4989e179c24f58c

Reverted - causing fatal errors on any page that accesses Tu

Thu, 08 Mar 2012 19:39:59 +0000

Reverted - causing fatal errors on any page that accesses Turba's API. Error: Fatal error: Call to a member function get() on a non-object in /disk2/src/horde/turba/lib/Turba.php on line 452

Changes have been made in Git (develop): commit 2424ea5ba64

Thu, 08 Mar 2012 19:40:57 +0000

Changes have been made in Git (develop): commit 2424ea5ba64ffb9e566cc148f6db9c8497d0e99a Author: Michael M Slusarz Date: Thu Mar 8 12:38:11 2012 -0700 Revert "[mjr] Properly cache empty listShares results (Bug #11045)." This reverts commit fc4877ab48a28d5375f7a42af4989e179c24f58c. This is causing fatal errors on any access to Turba. framework/Share/lib/Horde/Share/Sql.php | 6 +++--- framework/Share/lib/Horde/Share/Sqlng.php | 6 +++--- framework/Share/package.xml | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) http://git.horde.org/horde-git/-/commit/2424ea5ba64ffb9e566cc148f6db9c8497d0e99a

Changes have been made in Git (develop): commit 0cdd9e9d581

Thu, 08 Mar 2012 21:47:16 +0000

Changes have been made in Git (develop): commit 0cdd9e9d58135f152973c3c4648f32f312d8bb92 Author: Michael J Rubinsky Date: Thu Mar 8 16:44:44 2012 -0500 Revert "Revert "[mjr] Properly cache empty listShares results (Bug #11045)."" This reverts commit 2424ea5ba64ffb9e566cc148f6db9c8497d0e99a. framework/Share/lib/Horde/Share/Sql.php | 6 +++--- framework/Share/lib/Horde/Share/Sqlng.php | 6 +++--- framework/Share/package.xml | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) http://git.horde.org/horde-git/-/commit/0cdd9e9d58135f152973c3c4648f32f312d8bb92

Typo fixed by: 55f60efb24d39dd1758a21b130a71e058d457462

Thu, 08 Mar 2012 21:48:54 +0000

Typo fixed by: 55f60efb24d39dd1758a21b130a71e058d457462

List shares is now caching a false value if $sharelist is em

Wed, 14 Mar 2012 14:58:16 +0000

List shares is now caching a false value if $sharelist is empty. $this->_listcache[$key] = empty($sharelist) ? false : $sharelist; The problem is that on the first run the method will return false, but on the second run, because of: return is_array($this->_listcache[$key]) ? $this->_listcache[$key] : array(); it will return an empty array. Shouldn't it always return an empty array?

This has been fixed already.

Wed, 14 Mar 2012 15:14:00 +0000

This has been fixed already.

Sorry forgot to check the develop branch > This has been

Wed, 14 Mar 2012 17:05:52 +0000

Sorry forgot to check the develop branch > This has been fixed already.

Changes have been made in Git (master): commit fc4877ab48a2

Wed, 29 Aug 2012 12:32:25 +0000

Changes have been made in Git (master): commit fc4877ab48a28d5375f7a42af4989e179c24f58c Author: Michael J Rubinsky Date: Thu Mar 8 00:18:02 2012 -0500 [mjr] Properly cache empty listShares results (Bug #11045). framework/Share/lib/Horde/Share/Sql.php | 6 +++--- framework/Share/lib/Horde/Share/Sqlng.php | 6 +++--- framework/Share/package.xml | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) http://git.horde.org/horde-git/-/commit/fc4877ab48a28d5375f7a42af4989e179c24f58c

Changes have been made in Git (master): commit 2424ea5ba64f

Wed, 29 Aug 2012 12:32:34 +0000

Changes have been made in Git (master): commit 2424ea5ba64ffb9e566cc148f6db9c8497d0e99a Author: Michael M Slusarz Date: Thu Mar 8 12:38:11 2012 -0700 Revert "[mjr] Properly cache empty listShares results (Bug #11045)." This reverts commit fc4877ab48a28d5375f7a42af4989e179c24f58c. This is causing fatal errors on any access to Turba. framework/Share/lib/Horde/Share/Sql.php | 6 +++--- framework/Share/lib/Horde/Share/Sqlng.php | 6 +++--- framework/Share/package.xml | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) http://git.horde.org/horde-git/-/commit/2424ea5ba64ffb9e566cc148f6db9c8497d0e99a

Changes have been made in Git (master): commit 0cdd9e9d5813

Wed, 29 Aug 2012 12:32:38 +0000

Changes have been made in Git (master): commit 0cdd9e9d58135f152973c3c4648f32f312d8bb92 Author: Michael J Rubinsky Date: Thu Mar 8 16:44:44 2012 -0500 Revert "Revert "[mjr] Properly cache empty listShares results (Bug #11045)."" This reverts commit 2424ea5ba64ffb9e566cc148f6db9c8497d0e99a. framework/Share/lib/Horde/Share/Sql.php | 6 +++--- framework/Share/lib/Horde/Share/Sqlng.php | 6 +++--- framework/Share/package.xml | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) http://git.horde.org/horde-git/-/commit/0cdd9e9d58135f152973c3c4648f32f312d8bb92