horde-set-perms not working

The script 'horde-set-perms', which should set permissions f

Fri, 13 Jan 2012 08:34:08 +0000

The script 'horde-set-perms', which should set permissions for the installed horde-tree, is not working, because it compares group- and owner-names to numerical group- and owner-ids as returned by php, and is not handling directories. Please find attached a patch for these problems.

Changes have been made in Git for this ticket: [jan] Fix ho

Mon, 16 Jan 2012 12:57:58 +0000

Changes have been made in Git for this ticket: [jan] Fix horde-set-perms (piper@hrz.uni-marburg.de, Bug #10923). 3 files changed, 11 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/8c9fe1942e25b0f7af71ac873c119a4ef65718f6

> The script 'horde-set-perms', which should set permissions

Mon, 16 Jan 2012 12:58:07 +0000

> The script 'horde-set-perms', which should set permissions for the > installed horde-tree, is not working, because it compares group- and > owner-names to numerical group- and owner-ids as returned by php, and > is not handling directories. Please find attached a patch for these > problems. I left out the explicit setting of HORDE_BASE, because the iterator already includes it. The RecursiveIteratorIterator::SELF_FIRST flag wasn't necessary either.

the single quotes in line 48 $grouppars = posix_getgrnam('$

Wed, 18 Jan 2012 07:24:09 +0000

the single quotes in line 48 $grouppars = posix_getgrnam('$group'); have to be left out for being able to resolve the variable. > I left out the explicit setting of HORDE_BASE, because the iterator > already includes it. The RecursiveIteratorIterator::SELF_FIRST flag > wasn't necessary either. Without the RecursiveIteratorIterator::SELF_FIRST flag only files are changed, all directories are completely ignored in my test-setup. And even with this flag set, the HORDE_BASE directory is not changed, therefore I set it explicitely.

Changes have been made in Git for this ticket: Remove quote

Wed, 18 Jan 2012 10:23:07 +0000

Changes have been made in Git for this ticket: Remove quotes (Bug #10923). 1 files changed, 1 insertions(+), 1 deletions(-) http://git.horde.org/horde-git/-/commit/c704e141e6326a7916d0fa528580c82f3d9c3924

>> I left out the explicit setting of HORDE_BASE, because th

Wed, 18 Jan 2012 10:24:35 +0000

>> I left out the explicit setting of HORDE_BASE, because the iterator >> already includes it. The RecursiveIteratorIterator::SELF_FIRST flag >> wasn't necessary either. > > Without the RecursiveIteratorIterator::SELF_FIRST flag only files are > changed, all directories are completely ignored in my test-setup. And > even with this flag set, the HORDE_BASE directory is not changed, > therefore I set it explicitely. There is something wrong with your PHP then. RecursiveIteratorIterator::SELF_FIRST only changes the order of the iterator elements. It doesn't change whether directories are included or not.

> > There is something wrong with your PHP then. > Recurs

Fri, 20 Jan 2012 07:50:45 +0000

> > There is something wrong with your PHP then. > RecursiveIteratorIterator::SELF_FIRST only changes the order of the > iterator elements. It doesn't change whether directories are included > or not. PHP-documentation states that the default mode is RecursiveIteratorIterator::LEAVES_ONLY, which returns only files including 'path/..' and sometimes 'path/.' for my setup. Due to the '!$it->isDot()'-restriction, the dot-entries are skipped, so no directories are changed. Changing the restriction to 'if ($val->getFilename() != '..' )', gets most of the directories and leaves 'HORDE_BASE/..' unchanged, but RecursiveIteratorIterator::SELF_FIRST still is necessary for those directories not returned as 'path/.' I include a patch to your last version with these changes here.

Changes have been made in Git (refs/heads/master): commit 8

Mon, 30 Jan 2012 15:05:38 +0000

Changes have been made in Git (refs/heads/master): commit 8ee55fca30cb7ba88bf6a9dbdb8db20b3334d9dc Author: Jan Schneider Date: Mon Jan 30 16:04:14 2012 +0100 Fix completely (Bug #10923). horde/bin/horde-set-perms | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/8ee55fca30cb7ba88bf6a9dbdb8db20b3334d9dc

Changes have been made in Git (refs/heads/develop): commit

Mon, 30 Jan 2012 18:11:25 +0000

Changes have been made in Git (refs/heads/develop): commit 8ee55fca30cb7ba88bf6a9dbdb8db20b3334d9dc Author: Jan Schneider Date: Mon Jan 30 16:04:14 2012 +0100 Fix completely (Bug #10923). horde/bin/horde-set-perms | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/8ee55fca30cb7ba88bf6a9dbdb8db20b3334d9dc

Changes have been made in Git (refs/heads/ajax_to_core): co

Wed, 01 Feb 2012 20:26:23 +0000

Changes have been made in Git (refs/heads/ajax_to_core): commit 8ee55fca30cb7ba88bf6a9dbdb8db20b3334d9dc Author: Jan Schneider Date: Mon Jan 30 16:04:14 2012 +0100 Fix completely (Bug #10923). horde/bin/horde-set-perms | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/8ee55fca30cb7ba88bf6a9dbdb8db20b3334d9dc